linux-kernel - Re: [PATCH net-next] bnxt_en: Allow ntuple filters for drops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLikSduOjOtnPkFA=3SfWZvqfvPViKhcO9QsyO1eqt3r4Tg@mail.gmail.com>
Date: Wed, 28 Jan 2026 18:24:19 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: Joe Damato <joe@...a.to>, Michael Chan <michael.chan@...adcom.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Pavan Chebbi <pavan.chebbi@...adcom.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	shruti.parab@...adcom.com
Subject: Re: [PATCH net-next] bnxt_en: Allow ntuple filters for drops

On Wed, Jan 28, 2026 at 5:01 PM Joe Damato <joe@...a.to> wrote:
>
> On Wed, Jan 28, 2026 at 03:09:21PM -0800, Michael Chan wrote:
> > Alternatively, we can also change ethtool_get_flow_spec_ring_vf() to
> > check that the cookie is not RX_CLS_FLOW_DISC or RX_CLS_FLOW_WAKE.
>
> That's up to the maintainers.
>
> The existing drivers I checked which use ethtool_get_flow_spec_ring_vf all
> explicitly check RX_CLS_FLOW_DISC, so it seems to be an established pattern.
>
> I think we should fix this in the broadcom driver first and if there is a
> desire from the maintainers to handle this in ethtool_get_flow_spec_ring_vf,
> that can be done as a separate series which updates all of the drivers to
> remove the redundant check.

Sounds good.  Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5469 bytes)