linux-kernel - Re: [PATCH] tracing: Fix indentation of return statement in print_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260129112905.5840a45972274dd0048e36f3@kernel.org>
Date: Thu, 29 Jan 2026 11:29:05 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Haoyang LIU <tttturtleruss@...il.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, linux-kernel@...r.kernel.org (open
 list:TRACING), linux-trace-kernel@...r.kernel.org (open list:TRACING)
Subject: Re: [PATCH] tracing: Fix indentation of return statement in
 print_trace_fmt()

On Thu, 29 Jan 2026 09:39:54 +0800
Haoyang LIU <tttturtleruss@...il.com> wrote:

> The return statement inside the nested if block in print_trace_fmt()
> is not properly indented, making the code structure unclear. This was
> flagged by smatch as a warning.
> 
> Add proper indentation to the return statement to match the kernel
> coding style and improve readability.
> 
> Signed-off-by: Haoyang LIU <tttturtleruss@...il.com>

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Thanks,

> ---
>  kernel/trace/trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 8bd4ec08fb36..bf0ce2aac177 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -4286,7 +4286,7 @@ static enum print_line_t print_trace_fmt(struct trace_iterator *iter)
>  			/* ftrace and system call events are still OK */
>  			if ((event->type > __TRACE_LAST_TYPE) &&
>  			    !is_syscall_event(event))
> -			return print_event_fields(iter, event);
> +				return print_event_fields(iter, event);
>  		}
>  		return event->funcs->trace(iter, sym_flags, event);
>  	}
> -- 
> 2.25.1
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>