linux-kernel - RE: [Intel-wired-lan] [PATCH iwl-next v6] ice: add support for unmanaged DPLL on E830 NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB75229EA31240F5EBC09E9429A09EA@PH0PR11MB7522.namprd11.prod.outlook.com>
Date: Thu, 29 Jan 2026 03:59:01 +0000
From: "Mekala, SunithaX D" <sunithax.d.mekala@...el.com>
To: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Kubalewski,
 Arkadiusz" <arkadiusz.kubalewski@...el.com>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Fodor, Zoltan" <zoltan.fodor@...el.com>,
	"horms@...nel.org" <horms@...nel.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Grinberg, Vitaly" <vgrinber@...hat.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v6] ice: add support for
 unmanaged DPLL on E830 NIC

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Arkadiusz Kubalewski
> Sent: Tuesday, January 20, 2026 5:05 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: pmenzel@...gen.mpg.de; linux-doc@...r.kernel.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Kubalewski, Arkadiusz <arkadiusz.kubalewski@...el.com>; Loktionov, > Aleksandr <aleksandr.loktionov@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Fodor, Zoltan <zoltan.fodor@...el.com>; horms@...nel.org; Kitszel, Przemyslaw > <przemyslaw.kitszel@...el.com>; Grinberg, Vitaly <vgrinber@...hat.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v6] ice: add support for unmanaged DPLL on E830 NIC
>
> Hardware variants of E830 may support an unmanaged DPLL where the
> configuration is hardcoded within the hardware and firmware, meaning
> users cannot modify settings. However, users are able to check the DPLL
> lock status and obtain configuration information through the Linux DPLL
> and devlink health subsystem.
>
> Availability of 'loss of lock' health status code determines if such
> support is available, if true, register single DPLL device with 1 input
> and 1 output and provide hardcoded/read only properties of a pin and
> DPLL device. User is only allowed to check DPLL device status and receive
> notifications on DPLL lock status change.
>
> When present, the DPLL device locks to an external signal provided
> through the PCIe/OCP pin. The expected input signal is 1PPS
> (1 Pulse Per Second) embedded on a 10MHz reference clock.
> The DPLL produces output:
> - for MAC (Media Access Control) & PHY (Physical Layer) clocks,
> - 1PPS for synchronization of onboard PHC (Precision Hardware Clock) timer.
>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@...el.com>
> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
> ---
> v6:
> - change dpll type EEC -> PPS, this dpll serves both functionalisites but PPS
>  is superset of EEC type
> - use DPLL_MODE_MANUAL instead of AUTOMATIC, which is correct for the input
>   pins that doesn't have capability to set the priority
> v5:
> - rebased (baseline does not include dependent e825C patches now)
> - added health status notification (thru devlink and DPLL subsystem)
> v4:
> - add correct strcuture for reading supported health status codes and
>  use it to parse the outcome of 0xFF21 AQ command.
> ---
>  .../device_drivers/ethernet/intel/ice.rst     |  83 +++++
>  .../net/ethernet/intel/ice/devlink/health.c   |   4 +
>  .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  12 +
>  drivers/net/ethernet/intel/ice/ice_common.c   | 135 ++++++++
>  drivers/net/ethernet/intel/ice/ice_common.h   |   8 +
>  drivers/net/ethernet/intel/ice/ice_dpll.c     | 310 ++++++++++++++++--
>  drivers/net/ethernet/intel/ice/ice_dpll.h     |  11 +
>  drivers/net/ethernet/intel/ice/ice_main.c     |  14 +-
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.c   |  46 +++
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.h   |   1 +
>  10 files changed, 602 insertions(+), 22 deletions(-)

Tested-by: Sunitha Mekala <sunithax.d.mekala@...el.com> (A Contingent worker at Intel)