linux-kernel - Re: [PATCH v2 1/2] efi/libstub: enable apple-set-os for all apple devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260129043759.1220-1-atharvatiwarilinuxdev@gmail.com>
Date: Thu, 29 Jan 2026 04:37:59 +0000
From: Atharva Tiwari <atharvatiwarilinuxdev@...il.com>
To: lukas@...ner.de
Cc: airlied@...il.com,
	ardb@...nel.org,
	atharvatiwarilinuxdev@...il.com,
	bp@...en8.de,
	dri-devel@...ts.freedesktop.org,
	francescopompo2@...il.com,
	intel-gfx@...ts.freedesktop.org,
	intel-xe@...ts.freedesktop.org,
	jani.nikula@...ux.intel.com,
	javierm@...hat.com,
	joonas.lahtinen@...ux.intel.com,
	linux-efi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	lszubowi@...hat.com,
	rodrigo.vivi@...el.com,
	simona@...ll.ch,
	tursulin@...ulin.net,
	tzimmermann@...e.de
Subject: Re: [PATCH v2 1/2] efi/libstub: enable apple-set-os for all apple devices

> As discussed previously, your patch will regress older MacBook Airs
> which use SPI to access keyboard + trackpad if the set_os protocol
> is invoked:
> 
> https://lore.kernel.org/all/ZoJPgSlZJ3ZlU2zL@wunner.de/
> 
> The last time this topic came up, I suggested counting the number of
> GPUs instead of using the DMI quirk.  I even provided a patch but
> nobody with an eGPU bothered to test it, so the thread fizzled out:
> 
> https://lore.kernel.org/all/Z6paeFrjdv7L3mtv@wunner.de/
> 
> Maybe you could give it a spin and verify if it fixes the issue for you?

I tested your patch, and well it works (you still need the 2nd patch to 
avoid a blank screen), but i can see how this will fail
like for example, with the iMacPro (only has dGPU) you would need 2 eGPUs
to turn on apple-set-os.

My opinion is, we disable apple-set-os using a dmi check on the 2013/2014
MacbookAir models.