linux-kernel - Re: [PATCH] mmc: loongson2-mmc: drop redundant memset after dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9fd0f4c4-83b8-47f2-8480-1770ff254b4c@loongson.cn>
Date: Thu, 29 Jan 2026 13:04:05 +0800
From: Binbin Zhou <zhoubinbin@...ngson.cn>
To: Andre Korol <andre.korol.dev@...il.com>, ulf.hansson@...aro.org
Cc: linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: loongson2-mmc: drop redundant memset after
 dma_alloc_coherent()


On 2026/1/29 11:59, Andre Korol wrote:
> dma_alloc_coherent() returns zeroed memory, so the memset() immediately
> after allocation is redundant.
>
> Signed-off-by: Andre Korol <andre.korol.dev@...il.com>
LGTM.
Reviewed-by: Binbin Zhou <zhoubinbin@...ngson.cn>
> ---
>   drivers/mmc/host/loongson2-mmc.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/loongson2-mmc.c b/drivers/mmc/host/loongson2-mmc.c
> index da3daab5f3d6..026cbd80f114 100644
> --- a/drivers/mmc/host/loongson2-mmc.c
> +++ b/drivers/mmc/host/loongson2-mmc.c
> @@ -846,7 +846,6 @@ static int ls2k2000_mmc_set_internal_dma(struct loongson2_mmc_host *host,
>   	if (!host->sg_cpu)
>   		return -ENOMEM;
>   
> -	memset(host->sg_cpu, 0, PAGE_SIZE);
>   	return 0;
>   }
>