linux-kernel - RE: [PATCH v4 2/5] rtc: pcf85363: support reporting battery switch-over via RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS4PR04MB936215FC06B8ACC0F0259223FB9EA@AS4PR04MB9362.eurprd04.prod.outlook.com>
Date: Thu, 29 Jan 2026 05:43:09 +0000
From: Lakshay Piplani <lakshay.piplani@....com>
To: "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
	"linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"wim@...ux-watchdog.org" <wim@...ux-watchdog.org>, "linux@...ck-us.net"
	<linux@...ck-us.net>, "linux-watchdog@...r.kernel.org"
	<linux-watchdog@...r.kernel.org>
CC: Vikash Bansal <vikash.bansal@....com>, Priyanka Jain
	<priyanka.jain@....com>, Shashank Rebbapragada
	<shashank.rebbapragada@....com>
Subject: RE: [PATCH v4 2/5] rtc: pcf85363: support reporting battery
 switch-over via RTC_VL



> -----Original Message-----
> From: Lakshay Piplani <lakshay.piplani@....com>
> Sent: Friday, November 21, 2025 5:42 PM
> To: alexandre.belloni@...tlin.com; linux-rtc@...r.kernel.org; linux-
> kernel@...r.kernel.org; robh@...nel.org; krzk+dt@...nel.org;
> conor+dt@...nel.org; devicetree@...r.kernel.org; wim@...ux-watchdog.org;
> linux@...ck-us.net; linux-watchdog@...r.kernel.org
> Cc: Vikash Bansal <vikash.bansal@....com>; Priyanka Jain
> <priyanka.jain@....com>; Shashank Rebbapragada
> <shashank.rebbapragada@....com>; Lakshay Piplani
> <lakshay.piplani@....com>
> Subject: [PATCH v4 2/5] rtc: pcf85363: support reporting battery switch-over
> via RTC_VL
> 
> Add battery switch-over reporting for PCF85263/PCF85363 using the standard
> RTC_VL_* ioctl interface. When the backup supply takes over, the BSF flag is
> exposed to userspace through RTC_VL_READ and can be cleared using
> RTC_VL_CLR.
> 
> This allows applications to detect loss of main power without relying on non-
> standard interfaces.
> 
> Signed-off-by: Lakshay Piplani <lakshay.piplani@....com>
> ---
> V3 -> V4:
> - No changes in v4.
> V2 -> V3:
> - Split into separate patches as suggested:
>   - Battery switch-over detection.
>   - Timestamp recording for TS pin and battery switch-over events.
>   - Offset calibration.
>   - Watchdog timer (to be reviewed by watchdog maintainers).
> - Dropped Alarm2 support
> - Switched to rtc_add_group() for sysfs attributes
> V1 -> V2:
> - Watchdog related changes due to removal of vendor specific properties
>   from device tree
>   * remove vendor DT knobs (enable/timeout/stepsize/repeat)
>   * use watchdog_init_timeout (with 10s default)
>   * derive clock_sel from final timeout
>   * default, repeat=true (repeat mode)
> - Fixed uninitalised warning on 'ret' (reported by kernel test robot)
> - Use dev_dbg instead of dev_info for debug related print messages
> - Minor cleanup and comments.
> 
>  drivers/rtc/rtc-pcf85363.c | 49 ++++++++++++++++++++++++++++++++++++--
>  1 file changed, 47 insertions(+), 2 deletions(-)
> 


Hi,

I'm sending a gentle reminder regarding the patches that I submitted in November. 
I haven't received any review comments yet, so I'd really appreciate it if you could have a look whenever you have some time.

Best Regards
Lakshay Piplani