linux-kernel - Re: [PATCH v3 1/4] arm64: dts: qcom: ipq9574: Add gpio details for eMMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c67b801b-c2a7-4546-bd31-c3291b690ba1@oss.qualcomm.com>
Date: Thu, 29 Jan 2026 13:23:00 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Varadarajan Narayanan <varadarajan.narayanan@....qualcomm.com>,
        andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org,
        krzk+dt@...nel.org, conor+dt@...nel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org
Cc: sumit.garg@....qualcomm.com, dmitry.baryshkov@....qualcomm.com
Subject: Re: [PATCH v3 1/4] arm64: dts: qcom: ipq9574: Add gpio details for
 eMMC

On 1/29/26 7:28 AM, Varadarajan Narayanan wrote:
> The RDP433 has NAND and eMMC variants. Presently, only NAND variant is
> supported. To enable support for eMMC variant, add the relevant GPIO
> related information.
> 
> Do not enable NAND by default here. Enable it in board specific DTS.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@....qualcomm.com>
> ---
> v3: Disable nand in ipq9574-rdp-common.dtsi and enable it where required.
>     Add 'Reviewed-by: Konrad Dybcio'
> ---

[...]

>  &qpic_bam {
> @@ -179,7 +211,7 @@ &qpic_nand {
>  	pinctrl-0 = <&qpic_snand_default_state>;
>  	pinctrl-names = "default";
>  
> -	status = "okay";
> +	status = "disabled";

This part should apply to the second patch, since you now broke NAND
for every board that had it running previously by disabling it in the
common DTSI and not immediately overriding it back.

This must not happen, since it impacts bisectability of the kernel tree

The solution is to squash this hunk above (not the addition of eMMC GPIOs)
with patch 3.

You can also drop the status=disabled in common.dtsi, since it's already
disabled in the SoC dtsi.

Konrad