linux-kernel - Re: [PATCH] iio: adc: ad4080: remove unused dec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260130173849.00004447@huawei.com>
Date: Fri, 30 Jan 2026 17:38:49 +0000
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
CC: Antoniu Miclaus <antoniu.miclaus@...log.com>, Lars-Peter Clausen
	<lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Jonathan
 Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko
	<andy@...nel.org>, Matti Vaittinen <mazziesaccount@...il.com>, "Fabio
 Estevam" <festevam@...x.de>, Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Chen-Yu Tsai <wens@...nel.org>, <linux-iio@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: ad4080: remove unused dec_rate field

On Fri, 30 Jan 2026 07:23:32 +0200
Andy Shevchenko <andriy.shevchenko@...el.com> wrote:

> On Thu, Jan 29, 2026 at 07:21:58PM +0200, Antoniu Miclaus wrote:
> > Remove unused dec_rate field from ad4080_state struct.
> > The driver reads/writes decimation rate directly from
> > hardware registers via ad4080_get_dec_rate() and
> > ad4080_set_dec_rate() functions.  
> 
> Jonathan, the changes look good to me, but the process wise it made badly.
> Up to you, if you want to apply this, but it might be confusing as this is
> definitely *not* a series.

I'm not planning to queue anything else non urgent for the coming 
merge window, so we have plenty of time to do a v2 nicely.

I'd not be against having this lot of cleanup as a series if it
had a clear cover letter stating tooling used to find them etc.
Whilst not one driver, and can merge independently that sort of grouping
is fine if it provides some value (such as background info).


Jonathan


> 
> Also some patches should probably have a v2, I haven't checked that.
>