[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20260130223237.GG1710902-mkhalfella@purestorage.com>
Date: Fri, 30 Jan 2026 14:32:37 -0800
From: Mohamed Khalfella <mkhalfella@...estorage.com>
To: Sagi Grimberg <sagi@...mberg.me>
Cc: Chaitanya Kulkarni <kch@...dia.com>, Christoph Hellwig <hch@....de>,
Jens Axboe <axboe@...nel.dk>, Keith Busch <kbusch@...nel.org>,
Aaron Dailey <adailey@...estorage.com>,
Randy Jennings <randyj@...estorage.com>,
John Meneghini <jmeneghi@...hat.com>,
Hannes Reinecke <hare@...e.de>, linux-nvme@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 09/14] nvme: Implement cross-controller reset
completion
On Sun 2026-01-04 23:15:53 +0200, Sagi Grimberg wrote:
>
>
> On 01/01/2026 1:51, Mohamed Khalfella wrote:
> > On Sat 2025-12-27 12:24:17 +0200, Sagi Grimberg wrote:
> >>> + log = kmalloc(sizeof(*log), GFP_KERNEL);
> >>> + if (!log)
> >>> + return;
> >>> +
> >>> + ret = nvme_get_log(ctrl, 0, NVME_LOG_CCR, 0x01,
> >>> + 0x00, log, sizeof(*log), 0);
> >>> + if (ret)
> >>> + goto out;
> >>> +
> >>> + spin_lock_irqsave(&ctrl->lock, flags);
> >>> + for (i = 0; i < le16_to_cpu(log->ne); i++) {
> >>> + entry = &log->entries[i];
> >>> + if (entry->ccrs == 0) /* skip in progress entries */
> >>> + continue;
> >> What does ccrs stand for?
> > Cross-Controller Reset Status
> >
> > 0x00 -> In Progress
> > 0x01 -> Success
> > 0x02 -> Failed
> > 0x03 - 0xff -> Reserved
>
> Let's add it as a proper enumeration please.
>
Done
Powered by blists - more mailing lists