linux-kernel - Re: [PATCH v4 2/3] PCI: dwc: ep: Add per-PF BAR and inbound ATU mapping support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c71700d-e4a5-496b-825e-01f346f73949@ti.com>
Date: Fri, 30 Jan 2026 09:42:43 +0530
From: Aksh Garg <a-garg7@...com>
To: Niklas Cassel <cassel@...nel.org>, Koichiro Den <den@...inux.co.jp>
CC: <linux-pci@...r.kernel.org>, <jingoohan1@...il.com>, <mani@...nel.org>,
	<lpieralisi@...nel.org>, <kwilczynski@...nel.org>, <robh@...nel.org>,
	<bhelgaas@...gle.com>, <Zhiqiang.Hou@....com>,
	<gustavo.pimentel@...opsys.com>, <linux-kernel@...r.kernel.org>,
	<s-vadapalli@...com>, <danishanwar@...com>
Subject: Re: [PATCH v4 2/3] PCI: dwc: ep: Add per-PF BAR and inbound ATU
 mapping support

On 29/01/26 19:44, Niklas Cassel wrote:
> On Thu, Jan 29, 2026 at 02:47:52PM +0530, Aksh Garg wrote:
>> -static void dw_pcie_ep_clear_ib_maps(struct dw_pcie_ep *ep, enum pci_barno bar)
>> +static void dw_pcie_ep_clear_ib_maps(struct dw_pcie_ep *ep, u8 func_no, enum pci_barno bar)
>>  {
>> +	struct dw_pcie_ep_func *ep_func = dw_pcie_ep_get_func_from_ep(ep, func_no);
>>  	struct dw_pcie *pci = to_dw_pcie_from_ep(ep);
>>  	struct device *dev = pci->dev;
>>  	unsigned int i, num;
>> @@ -152,18 +157,18 @@ static void dw_pcie_ep_clear_ib_maps(struct dw_pcie_ep *ep, enum pci_barno bar)
>>  	u32 *indexes;
> 
> Hello Aksh,
> 
> Considering that all other functions that you have modified, you have added a:
> 
> if (!ep_func)
> 	return;
> 
> 
> I think you should do the same to this function.
> 

I omitted this NULL check here because all the current call sites of
dw_pcie_ep_clear_ib_maps() already perform this validation. I felt
adding it here would add redundancy in the code.

> 
>>  
>>  	/* Tear down the BAR Match Mode mapping, if any. */
>> -	if (ep->bar_to_atu[bar]) {
>> -		atu_index = ep->bar_to_atu[bar] - 1;
>> +	if (ep_func->bar_to_atu[bar]) {
>> +		atu_index = ep_func->bar_to_atu[bar] - 1;
>>  		dw_pcie_disable_atu(pci, PCIE_ATU_REGION_DIR_IB, atu_index);
>>  		clear_bit(atu_index, ep->ib_window_map);
>> -		ep->bar_to_atu[bar] = 0;
>> +		ep_func->bar_to_atu[bar] = 0;