linux-kernel - Re: [PATCH] iio: adc: vf610: Add missing check for device_property_read_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXxAtFgmX0odYwne@smile.fi.intel.com>
Date: Fri, 30 Jan 2026 07:25:08 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Nuno Sá <noname.nuno@...il.com>,
	Chen Ni <nichen@...as.ac.cn>, haibo.chen@....com,
	dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
	linux-iio@...r.kernel.org, imx@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: vf610: Add missing check for
 device_property_read_u32_array

On Thu, Jan 29, 2026 at 05:40:21PM +0000, Jonathan Cameron wrote:
> On Wed, 28 Jan 2026 09:29:47 +0000
> Nuno Sá <noname.nuno@...il.com> wrote:
> > On Wed, 2026-01-28 at 12:27 +0800, Chen Ni wrote:

...

> Given the driver has a fallback for info->max_adck_rate[x] == 0
> I think this is intentional.  It would be clearer if this had done.
> 
> 	info->max_adck_rate[0] = 8;
> 	info->max_adck_rate[1] = 8;
> 	info->max_adck_rate[2] = 8;

Just in case, we have memset32() if it fits :-)

> 	device_property_read_u32_array(dev, "fsl,adck-max-frequency", info->max_adck_rate, 3);
> 
> though rather than where it has the fallback in vf610_adc_calculate_rates()
> 

-- 
With Best Regards,
Andy Shevchenko