linux-kernel - Re: [PATCH v5 11/31] clk: at91: clk-usb: add support for clk_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878697e8-9770-4707-83c8-e8c3834c4447@tuxon.dev>
Date: Fri, 30 Jan 2026 09:06:31 +0200
From: claudiu beznea <claudiu.beznea@...on.dev>
To: ryan.wanner@...rochip.com, mturquette@...libre.com, sboyd@...nel.org,
 nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
 bmasney@...hat.com, alexander.sverdlin@...il.com,
 varshini.rajendran@...rochip.com
Cc: cristian.birsan@...rochip.com, balamanikandan.gunasundar@...rochip.com,
 linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 11/31] clk: at91: clk-usb: add support for
 clk_parent_data

Hi, Ryan,

On 1/16/26 22:07, ryan.wanner@...rochip.com wrote:
> @@ -818,18 +817,22 @@ static void __init sam9x7_pmc_setup(struct device_node *np)
>   				switch (sam9x7_plls[i][j].p) {
>   				case SAM9X7_PLL_PARENT_MAINCK:
>   					parent_data[0] = AT91_CLK_PD_NAME("mainck");
> -					hw = sam9x7_pmc->chws[PMC_MAIN];
> +					parent_rate = clk_hw_get_rate(sam9x7_pmc->chws[PMC_MAIN]);
>   					break;
>   				case SAM9X7_PLL_PARENT_MAIN_XTAL:
> +					struct clk *main_xtal;
> +					main_xtal = of_clk_get_by_name(np, main_xtal_name);
> +					if (IS_ERR(main_xtal))
> +						goto err_free;
>   					parent_data[0] = AT91_CLK_PD_NAME(main_xtal_name);
> -					hw = main_xtal_hw;
> +					parent_rate = clk_get_rate(main_xtal);
> +					clk_put(main_xtal);
>   					break;

Could you please let me know why is this change related to USB? It looks to me 
that it should go in a different patch. Same for the similar changes done on 
sama7d65.c. Sorry for not noticing it previously.

The rest LGTM.

Thank you,
Claudiu