| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CABVgOSnXP_7dR72XtjiCUX5L8s85KZ6DzeqsOVV5RGE70yZ6og@mail.gmail.com>
Date: Fri, 30 Jan 2026 15:43:00 +0800
From: David Gow <davidgow@...gle.com>
To: Lyude Paul <lyude@...hat.com>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
Thomas Gleixner <tglx@...utronix.de>, Boqun Feng <boqun.feng@...il.com>,
Daniel Almeida <daniel.almeida@...labora.com>, Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
Danilo Krummrich <dakr@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>,
Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
Waiman Long <longman@...hat.com>
Subject: Re: [PATCH v17 06/16] irq: Add KUnit test for refcounted interrupt enable/disable
On Thu, 22 Jan 2026 at 06:43, Lyude Paul <lyude@...hat.com> wrote:
>
> While making changes to the refcounted interrupt patch series, at some
> point on my local branch I broke something and ended up writing some kunit
> tests for testing refcounted interrupts as a result. So, let's include
> these tests now that we have refcounted interrupts.
>
> Signed-off-by: Lyude Paul <lyude@...hat.com>
>
> ---
Looks good to me. Not sure if it'd make sense to move this into
kernel/irq/irq_test.c alongside other IRQs, or if you like having it
separate. I'm happy either way.
Reviewed-by: David Gow <davidgow@...gle.com>
Cheers,
-- David
> V13:
> * Add missing MODULE_DESCRIPTION/MODULE_LICENSE lines
> * Switch from kunit_test_suites(…) to kunit_test_suite(…)
>
> kernel/irq/Makefile | 1 +
> kernel/irq/refcount_interrupt_test.c | 109 +++++++++++++++++++++++++++
> 2 files changed, 110 insertions(+)
> create mode 100644 kernel/irq/refcount_interrupt_test.c
>
> diff --git a/kernel/irq/Makefile b/kernel/irq/Makefile
> index 6ab3a40556670..7b5bb5510b110 100644
> --- a/kernel/irq/Makefile
> +++ b/kernel/irq/Makefile
> @@ -20,3 +20,4 @@ obj-$(CONFIG_SMP) += affinity.o
> obj-$(CONFIG_GENERIC_IRQ_DEBUGFS) += debugfs.o
> obj-$(CONFIG_GENERIC_IRQ_MATRIX_ALLOCATOR) += matrix.o
> obj-$(CONFIG_IRQ_KUNIT_TEST) += irq_test.o
> +obj-$(CONFIG_KUNIT) += refcount_interrupt_test.o
> diff --git a/kernel/irq/refcount_interrupt_test.c b/kernel/irq/refcount_interrupt_test.c
> new file mode 100644
> index 0000000000000..b4f224595f261
> --- /dev/null
> +++ b/kernel/irq/refcount_interrupt_test.c
> @@ -0,0 +1,109 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * KUnit test for refcounted interrupt enable/disables.
> + */
> +
> +#include <kunit/test.h>
> +#include <linux/interrupt_rc.h>
> +
> +#define TEST_IRQ_ON() KUNIT_EXPECT_FALSE(test, irqs_disabled())
> +#define TEST_IRQ_OFF() KUNIT_EXPECT_TRUE(test, irqs_disabled())
> +
> +/* ===== Test cases ===== */
> +static void test_single_irq_change(struct kunit *test)
> +{
> + local_interrupt_disable();
> + TEST_IRQ_OFF();
> + local_interrupt_enable();
> +}
> +
> +static void test_nested_irq_change(struct kunit *test)
> +{
> + local_interrupt_disable();
> + TEST_IRQ_OFF();
> + local_interrupt_disable();
> + TEST_IRQ_OFF();
> + local_interrupt_disable();
> + TEST_IRQ_OFF();
> +
> + local_interrupt_enable();
> + TEST_IRQ_OFF();
> + local_interrupt_enable();
> + TEST_IRQ_OFF();
> + local_interrupt_enable();
> + TEST_IRQ_ON();
> +}
> +
> +static void test_multiple_irq_change(struct kunit *test)
> +{
> + local_interrupt_disable();
> + TEST_IRQ_OFF();
> + local_interrupt_disable();
> + TEST_IRQ_OFF();
> +
> + local_interrupt_enable();
> + TEST_IRQ_OFF();
> + local_interrupt_enable();
> + TEST_IRQ_ON();
> +
> + local_interrupt_disable();
> + TEST_IRQ_OFF();
> + local_interrupt_enable();
> + TEST_IRQ_ON();
> +}
> +
> +static void test_irq_save(struct kunit *test)
> +{
> + unsigned long flags;
> +
> + local_irq_save(flags);
> + TEST_IRQ_OFF();
> + local_interrupt_disable();
> + TEST_IRQ_OFF();
> + local_interrupt_enable();
> + TEST_IRQ_OFF();
> + local_irq_restore(flags);
> + TEST_IRQ_ON();
> +
> + local_interrupt_disable();
> + TEST_IRQ_OFF();
> + local_irq_save(flags);
> + TEST_IRQ_OFF();
> + local_irq_restore(flags);
> + TEST_IRQ_OFF();
> + local_interrupt_enable();
> + TEST_IRQ_ON();
> +}
> +
> +static struct kunit_case test_cases[] = {
> + KUNIT_CASE(test_single_irq_change),
> + KUNIT_CASE(test_nested_irq_change),
> + KUNIT_CASE(test_multiple_irq_change),
> + KUNIT_CASE(test_irq_save),
> + {},
> +};
> +
> +/* (init and exit are the same */
> +static int test_init(struct kunit *test)
> +{
> + TEST_IRQ_ON();
> +
> + return 0;
> +}
> +
> +static void test_exit(struct kunit *test)
> +{
> + TEST_IRQ_ON();
> +}
> +
> +static struct kunit_suite refcount_interrupt_test_suite = {
> + .name = "refcount_interrupt",
> + .test_cases = test_cases,
> + .init = test_init,
> + .exit = test_exit,
> +};
> +
> +kunit_test_suite(refcount_interrupt_test_suite);
> +MODULE_AUTHOR("Lyude Paul <lyude@...hat.com>");
> +MODULE_DESCRIPTION("Refcounted interrupt unit test suite");
> +MODULE_LICENSE("GPL");
> --
> 2.52.0
>
>
Download attachment "smime.p7s" of type "application/pkcs7-signature" (5281 bytes)
Powered by blists - more mailing lists