linux-kernel - Re: [PATCH v4 1/5] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXxvXqZeZSHoivFH@stanley.mountain>
Date: Fri, 30 Jan 2026 11:44:14 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Luka Gejak <lukagejak5@...il.com>
Cc: gregkh@...uxfoundation.org, straube.linux@...il.com,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v4 1/5] staging: rtl8723bs: fix potential out-of-bounds
 read in rtw_restruct_wmm_ie

Please, slow down.  Only resend a patchset once per day.

On Thu, Jan 29, 2026 at 07:15:37PM +0100, Luka Gejak wrote:
> The current code checks 'i + 5 < in_len' at the end of
> the if statement.
> However, it accesses 'in_ie[i + 5]' before that check,
> which can lead to an out-of-bounds read.

The line breaks are weird looking.  You're putting a new line between
sentences and a blank line between paragraphs.  Just put a blank line
between paragraphs and delete the extra newline.

The out of bounds read is most likely going to be harmless.  Hopefully,
it would be detected and trigger a warning from the UBSan type tools.
Also if you got really unlucky and in_ie[] was at the end of a page
then it could cause a crash.

This bug is still definitely worth fixing.

> 
> Move the length check to the beginning of the conditional
> to ensure the index is within bounds before accessing the array.
> 
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
> 
> Cc: stable@...r.kernel.org
> 
> Signed-off-by: Luka Gejak <lukagejak5@...il.com>

Delete the blank lines in the S-o-b block.

regards,
dan carpenter