linux-kernel - Re: [PATCH v9 3/4] irqchip/loongarch-avec.c:return IRQ_SET_MASK_OK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e36a4c6e-1113-ec35-56ee-3655004b64d5@loongson.cn>
Date: Fri, 30 Jan 2026 17:05:44 +0800
From: Tianyang Zhang <zhangtianyang@...ngson.cn>
To: Thomas Gleixner <tglx@...nel.org>, chenhuacai@...nel.org,
 kernel@...0n.name, corbet@....net, alexs@...nel.org, si.yanteng@...ux.dev,
 jiaxun.yang@...goat.com, maobibo@...ngson.cn
Cc: loongarch@...ts.linux.dev, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 3/4] irqchip/loongarch-avec.c:return
 IRQ_SET_MASK_OK_DONE when keep affinity

Hi, Thomas

在 2026/1/30 下午4:20, Thomas Gleixner 写道:
> On Fri, Jan 30 2026 at 10:59, Tianyang Zhang wrote:
>
>    irqchip/irq-loonarch-avec: Return IRQ_SET_MASK_OK_DONE when affinity is unchanged
>
> Note the space between 'prefix: ' and the shortlog sentence
Ok, I got it
>
>> When it is detected in avecintc_set_affinity that the current affinity
> Functions are denoted with fname() to make it clear. See
>
> https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-submission-notes
Ok, I got it
>
>> remains valid, the return value is modified to IRQ_SET_MASK_OK_DONE.
> That's the very wrong order of explaining the change. You again explain
> the _what_ first without giving context and reason.
>
> See the above link. It provides guidance about structuring a change log.
Ok, I will rewrite this changelog
>
>> After the introduction of redirect-domain, for each interrupt source,
>> avecintc-domain only provides the CPU/interrupt vector, while redirect-domain
>> provides other operations to synchronize interrupt affinity information
>> among multiple cores. The original intention is to notify the cascaded
>> redirect_set_affinity that multi-core synchronization is not required.
> "After the introduction.." is confusing at best.
Ok, I got it
>
>> However, this introduces some compatibility issues, such as the new return
>> value causing msi_domain_set_affinity to no longer perform irq_chip_write_msi_msg.
>>    1) When redirect exist in the system, the msi msg_address and msg_data no
>> longer changes after the allocation phase, so it does not actually require updating
>> the MSI message info.
>>    2) When only avecintc exists in the system, the irq_domain_activate_irq
>> interface will be responsible for the initial configuration of the MSI message,
>> which is unconditional. After that, if unnecessary, no modification to the MSI
>> message is alse correctly.
> Spell checkers exist for a reason.

Ok, I got it

Thanks

>
> Thanks
>
>          tglx