linux-kernel - Re: [PATCH v5] stm: class: Add MIPI OST protocol support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83qzr7a0tm.fsf@black.igk.intel.com>
Date: Fri, 30 Jan 2026 10:48:05 +0100
From: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To: Yingchao Deng <yingchao.deng@....qualcomm.com>, Steven Rostedt
 <rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Jonathan Corbet
 <corbet@....net>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre
 Torgue <alexandre.torgue@...s.st.com>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, quic_yingdeng@...cinc.com, Tingwei
 Zhang <tingwei.zhang@....qualcomm.com>, Yuanfang Zhang
 <yuanfang.zhang@....qualcomm.com>, Jinlong Mao
 <jinlong.mao@....qualcomm.com>, Yingchao Deng
 <yingchao.deng@....qualcomm.com>, alexander.shishkin@...ux.intel.com
Subject: Re: [PATCH v5] stm: class: Add MIPI OST protocol support

Yingchao Deng <yingchao.deng@....qualcomm.com> writes:

> +	for (i = 1; i < ARRAY_SIZE(str_ost_entity_type); i++) {
> +		if (i == pn->entity_type)
> +			sz += sysfs_emit_at(page, sz, "[%s] ", str_ost_entity_type[i]);
> +		else
> +			sz += sysfs_emit_at(page, sz, "%s ", str_ost_entity_type[i]);
> +	}

Greg hates this. Documentation [0] says "preferably": "Attributes should
be ASCII text files, preferably with only one value per file.", but
somebody will get yelled at if this gets spotted, and since it's
probably going to be me, let's maybe not do this.

Also, the ST Microsystems people don't need to be CC'd on Software Trace
Module patches: it's the same TLA meaning 2 different things. Everybody
does this, so I'm assuming they're cool with it, but FYI.

[0] https://docs.kernel.org/filesystems/sysfs.html#attributes

Thanks,
--
Alex