linux-kernel - Re: [PATCH v4 2/3] PCI: dwc: ep: Add per-PF BAR and inbound ATU mapping support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXyAfilrBOe1cEEk@ryzen>
Date: Fri, 30 Jan 2026 10:57:18 +0100
From: Niklas Cassel <cassel@...nel.org>
To: Koichiro Den <den@...inux.co.jp>
Cc: Aksh Garg <a-garg7@...com>, linux-pci@...r.kernel.org,
	jingoohan1@...il.com, mani@...nel.org, lpieralisi@...nel.org,
	kwilczynski@...nel.org, robh@...nel.org, bhelgaas@...gle.com,
	Zhiqiang.Hou@....com, gustavo.pimentel@...opsys.com,
	linux-kernel@...r.kernel.org, s-vadapalli@...com,
	danishanwar@...com
Subject: Re: [PATCH v4 2/3] PCI: dwc: ep: Add per-PF BAR and inbound ATU
 mapping support

On Fri, Jan 30, 2026 at 11:21:32AM +0900, Koichiro Den wrote:
> > 
> > Koichiro (he is on To:),
> > 
> > don't you think that it would be clearer if we had a:
> > 		return;
> > 
> > here...
> > 
> > I mean, a BAR can either have a BAR match mode mapping or a subrange mapping,
> > but not both... So continuing executing code beyond this point seems pointless,
> > possibly even confusing.
> 
> Thanks for pinging. I agree it would be clearer. Since it's orthogonal to
> this series, would it be better if I sent a one-line patch?

Thank you Koichiro, I think a one liner patch for this would be nice.

You can also write in the changelog (after the ----) that Mani can squash
your one liner patch into the existing submap commit if he wants.


Kind regards,
Niklas