linux-kernel - Re: [PATCH v2 1/1] lib/crypto: tests: Add KUnit tests for AES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72667cb9-f30c-4a9d-97b1-355cc23d8b8e@linux.ibm.com>
Date: Fri, 30 Jan 2026 11:54:52 +0100
From: Holger Dengler <dengler@...ux.ibm.com>
To: Eric Biggers <ebiggers@...nel.org>
Cc: David Laight <david.laight.linux@...il.com>,
        Ard Biesheuvel <ardb@...nel.org>,
        "Jason A . Donenfeld" <Jason@...c4.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Harald Freudenberger <freude@...ux.ibm.com>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v2 1/1] lib/crypto: tests: Add KUnit tests for AES

On 29/01/2026 02:18, Eric Biggers wrote:
> "AES_BLOCK_SIZE * NSEC_PER_SEC" is missing a cast to u64, as reported by
> the kernel test robot.
> 
> But also as discussed in v1, using ktime_get_ns() to time one AES block
> en/decryption at a time doesn't really work.  Even on x86 which has a
> high precision timer, it's spending longer getting the time than doing
> the actual AES en/decryption.
> 
> You may have meant to use get_cycles() instead, which has less overhead.
> 
> However, not all architectures have a cycle counter.
> 
> So I recommend we go with the simple strategy that I suggested, and
> which v1 had.  Just the number of iterations in v1 was way too high.

Ok, I'll send a v3.

> 
> - Eric

-- 
Mit freundlichen Grüßen / Kind regards
Holger Dengler
--
IBM Systems, Linux on IBM Z Development
dengler@...ux.ibm.com