linux-kernel - Re: [PATCH v3 fwctl 2/5] fwctl/bnxt_en: Refactor aux bus functions to be more generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv2X4conD681Kb_q2DUzEahY08HErSUcNprhv_AiozZDhQ@mail.gmail.com>
Date: Fri, 30 Jan 2026 17:56:11 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>
Cc: jgg@...pe.ca, michael.chan@...adcom.com, linux-kernel@...r.kernel.org, 
	dave.jiang@...el.com, saeedm@...dia.com, gospo@...adcom.com, 
	selvin.xavier@...adcom.com, leon@...nel.org, 
	kalesh-anakkur.purayil@...adcom.com
Subject: Re: [PATCH v3 fwctl 2/5] fwctl/bnxt_en: Refactor aux bus functions to
 be more generic

> Hi Pavan,
>
> Various comments inline.  Please also make sure to run a few
> static analysis tools over the code. There seems to be a use
> after free that is pretty obvious in here, so I'd expect that
> to be picked up. That stuff is easier for tooling that humans!

Ok, I will respin for the UAF. I value your other comments, and I have
addressed them all until this patch. Because the new ones are not code
defects I am going to hold them off for a later time.
It seems like this auxdevice infra (which is not authored by me) can
be improved and simplified. I will plan to do that.
I have tried to improve it as best as I can to accommodate fwctl which
is the primary goal of the series.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5469 bytes)