Message-ID: <31ec74be-13b6-4d74-8643-6bd68659299b@panix.com>
Date: Thu, 29 Jan 2026 17:42:43 -0800
From: Kenneth Crudup <kenny@...ix.com>
To: "Katiyar, Pooja" <pooja.katiyar@...ux.intel.com>,
 "Mario Limonciello (AMD) (kernel.org)" <superm1@...nel.org>
Cc: "open list:THUNDERBOLT DRIVER" <linux-usb@...r.kernel.org>,
 linux-kernel@...r.kernel.org, Andreas Noever <andreas.noever@...il.com>,
 Yehezkel Bernat <YehezkelShB@...il.com>,
 Pooja Katiyar <pooja.katiyar@...el.com>,
 Rene Sapiens <rene.sapiens@...ux.intel.com>,
 Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH v2 0/2] thunderbolt: Fix S4 resume incongruities


BTW, I had no TB connectivity until I'd unplugged/replugged.

-Kenny

On 1/29/26 17:39, Kenneth Crudup wrote:
> 
>>> The issue I'm trying to chase down (and not sure if any of this will
>>> help with this, I wonder if it's really BIOS/EC related) is often times
>>> that after a suspend (or hibernate, but I use "suspend then hibernate",
>>> which I think does both and chooses which to use upon resume) and then
>>> connect to a different dock (or setup) from the one I'd suspended with,
>>> sometimes I have to unplug/replug my TB cable, otherwise I either get no
>>> recognition of my new display setup (and sometimes TB devices) or it'll
>>> try and use the same monitor resolution of the previously-connected
>>> monitor (as if the TB subsystem doesn't recognize things have changed).
> 
> On 1/29/26 15:13, Katiyar, Pooja wrote:
> 
>> Below is the patch series that addresses mentioned issue. There are two
>> patches in this series. The series takes care of releasing the DP 
>> resources
>> as part of freeze call before the hibernation image is created. You 
>> can test
>> it for your issues and let us know if it helps.
>>
>> Please note that these changes are still under internal review and are
>> subject to change.
> 
> I tested this against Linus' master (4d310797262) and while the jury is 
> still out on my issue (a few tests against different monitors looked 
> good, the big test is when I get back home later), I did see this on the 
> 3rd resume from hibernate (full dmesg attached):
> 
> ----
> [Thu Jan 29 17:25:10 2026] [   T5543] ------------[ cut here ]------------
> [Thu Jan 29 17:25:10 2026] [   T5543] WARNING: drivers/thunderbolt/ 
> tunnel.c:2358 at tb_tunnel_is_invalid+0x46/0x60, CPU#12: kworker/ 
> u80:19/5543
> [Thu Jan 29 17:25:10 2026] [   T5543] Modules linked in: intel_ipu6_isys 
> videobuf2_dma_sg ivsc_ace ivsc_csi intel_ishtp_hid iwlmvm 
> snd_soc_sof_sdw mac80211 r8152(O) mei_vsc iwlwifi snd_sof_pci_intel_tgl 
> snd_sof_pci_intel_cnl btusb cfg80211 intel_ish_ipc btintel intel_ishtp 
> intel_ipu6 mei_vsc_hw xe i2c_algo_bit drm_display_helper cec 
> drm_gpusvm_helper drm_buddy drm_suballoc_helper gpu_sched drm_ttm_helper 
> ttm drm_gpuvm drm_exec
> [Thu Jan 29 17:25:10 2026] [   T5543] CPU: 12 UID: 0 PID: 5543 Comm: 
> kworker/u80:19 Tainted: G S         O        6.19.0-rc7-kenny+ #33 PREEMPT
> [Thu Jan 29 17:25:10 2026] [   T5543] Tainted: [S]=CPU_OUT_OF_SPEC, 
> [O]=OOT_MODULE
> [Thu Jan 29 17:25:10 2026] [   T5543] Hardware name: Dell Inc. XPS 
> 9320/0KNXGD, BIOS 2.26.0 10/27/2025
> [Thu Jan 29 17:25:10 2026] [   T5543] Workqueue: thunderbolt1 
> tb_dp_dprx_work
> [Thu Jan 29 17:25:10 2026] [   T5543] RIP: 
> 0010:tb_tunnel_is_invalid+0x46/0x60
> [Thu Jan 29 17:25:10 2026] [   T5543] Code: 00 00 00 00 48 8b 43 20 48 
> 8b 3c c8 80 7f 22 00 74 18 e8 bd b0 ff ff 84 c0 75 1b 49 63 ce 44 8d 71 
> 01 48 39 4b 28 77 dc eb 0c <0f> 0b 48 8b 43 20 48 8b 3c c8 eb dc 5b 41 
> 5e 5d c3 31 c0 c3 cc cc
> [Thu Jan 29 17:25:10 2026] [   T5543] RSP: 0000:ffffa3dc86ebbbd0 EFLAGS: 
> 00010246
> [Thu Jan 29 17:25:10 2026] [   T5543] RAX: ffff938db2f6b8e0 RBX: 
> ffff938d59164c00 RCX: 0000000000000000
> [Thu Jan 29 17:25:10 2026] [   T5543] RDX: ffffa3dc86ebbc08 RSI: 
> ffffa3dc86ebbc0c RDI: ffff938d4efb7680
> [Thu Jan 29 17:25:10 2026] [   T5543] RBP: ffffa3dc86ebbbe0 R08: 
> 0000000000000000 R09: ffff938dc5344ac0
> [Thu Jan 29 17:25:10 2026] [   T5543] R10: 00000000000002bf R11: 
> 0000000000000400 R12: ffff938d412ed960
> [Thu Jan 29 17:25:10 2026] [   T5543] R13: ffff938d412ed0c8 R14: 
> 0000000000000001 R15: ffff938d42d30358
> [Thu Jan 29 17:25:10 2026] [   T5543] FS:  0000000000000000(0000) 
> GS:ffff939518d71000(0000) knlGS:0000000000000000
> [Thu Jan 29 17:25:10 2026] [   T5543] CS:  0010 DS: 0000 ES: 0000 CR0: 
> 0000000080050033
> [Thu Jan 29 17:25:10 2026] [   T5543] CR2: 0000000000000000 CR3: 
> 000000018aa0d001 CR4: 0000000000770ef0
> [Thu Jan 29 17:25:10 2026] [   T5543] PKRU: 55555554
> [Thu Jan 29 17:25:10 2026] [   T5543] Call Trace:
> [Thu Jan 29 17:25:10 2026] [   T5543]  <TASK>
> [Thu Jan 29 17:25:10 2026] [   T5543]  tb_consumed_dp_bandwidth+0xa8/0x1d0
> [Thu Jan 29 17:25:10 2026] [   T5543]  tb_available_bandwidth+0x333/0x450
> [Thu Jan 29 17:25:10 2026] [   T5543]  tb_reclaim_usb3_bandwidth+0x57/0x2a0
> [Thu Jan 29 17:25:10 2026] [   T5543]  tb_dp_tunnel_active+0x73/0x310
> [Thu Jan 29 17:25:10 2026] [   T5543]  ? tb_tunnel_event+0x131/0x160
> [Thu Jan 29 17:25:10 2026] [   T5543]  tb_dp_dprx_work+0xf4/0x110
> [Thu Jan 29 17:25:10 2026] [   T5543]  process_scheduled_works+0x1e7/0x370
> [Thu Jan 29 17:25:10 2026] [   T5543]  worker_thread+0x2ee/0x390
> [Thu Jan 29 17:25:10 2026] [   T5543]  kthread+0x237/0x250
> [Thu Jan 29 17:25:10 2026] [   T5543]  ? pr_cont_work+0x1c0/0x1c0
> [Thu Jan 29 17:25:10 2026] [   T5543]  ? kthread_blkcg+0x30/0x30
> [Thu Jan 29 17:25:10 2026] [   T5543]  ret_from_fork+0xc0/0x550
> [Thu Jan 29 17:25:10 2026] [   T5543]  ? __switch_to+0x134/0x460
> [Thu Jan 29 17:25:10 2026] [   T5543]  ? kthread_blkcg+0x30/0x30
> [Thu Jan 29 17:25:10 2026] [   T5543]  ret_from_fork_asm+0x11/0x20
> [Thu Jan 29 17:25:10 2026] [   T5543]  </TASK>
> [Thu Jan 29 17:25:10 2026] [   T5543] ---[ end trace 0000000000000000 ]---
> [Thu Jan 29 17:25:10 2026] [   T5543] ------------[ cut here ]------------
> ----
> 
> -Kenny
> 

-- 
Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange 
County CA

Powered by blists - more mailing lists