linux-kernel - Re: [PATCH 3/3] samples: rust: remove imports available via prelude

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb68b2d2-a5bd-4359-a0c5-019ef4060e7d@de.bosch.com>
Date: Fri, 30 Jan 2026 13:45:05 +0100
From: Dirk Behme <dirk.behme@...bosch.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Gary Guo
	<gary@...yguo.net>
CC: Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin
	<lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl
	<aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich
	<dakr@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael
 J. Wysocki" <rafael@...nel.org>, Dave Ertman <david.m.ertman@...el.com>, "Ira
 Weiny" <ira.weiny@...el.com>, Leon Romanovsky <leon@...nel.org>, Arnd
 Bergmann <arnd@...db.de>, <rust-for-linux@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] samples: rust: remove imports available via prelude

On 27/01/2026 12:10, Miguel Ojeda wrote:
> On Sat, Jan 24, 2026 at 6:08 AM Gary Guo <gary@...yguo.net> wrote:
>>
>> These imports are already in scope by importing `kernel::prelude::*` and
>> does not need to be imported separately.
>>
>> Signed-off-by: Gary Guo <gary@...yguo.net>
> 
> Applied (this one only) to `rust-next` -- thanks everyone!

Having my klint setup running now (many thanks Gary!) on today's 
rust-next [1] I still get

error: this item is available via prelude
   --> samples/rust/rust_driver_auxiliary.rs:12:5
    |
12 |     error::Error,
    |     ^^^^^^^^^^^^
    |
    = help: import with `kernel::prelude::*` instead
    = note: `-D klint::not-using-prelude` implied by `-D warnings`
    = help: to override `-D warnings` add 
`#[allow(klint::not_using_prelude)]`

error: aborting due to 1 previous error

Somehow dropping this was not part of this patch. Not sure why ...

Best regards

Dirk

[1] HEAD is 08afcc38a64c ("Merge patch series "Add support for print 
exactly once"")