linux-kernel - Re: [PATCH] bootconfig: Fix to terminate value search if it hits a newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260130095331.5c9f754e@gandalf.local.home>
Date: Fri, 30 Jan 2026 09:53:31 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: linux-trace-kernel@...r.kernel.org, Julius Werner <jwerner@...gle.com>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bootconfig: Fix to terminate value search if it hits a
 newline

On Fri, 30 Jan 2026 13:41:45 +0900
"Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:

> Note that if the line has a comment, it still keep searching the
> value to the next line::
> 
>   foo = # comment
>   value

Hmm, so the above is the same as: foo = "value";

But what is:

    foo = value # comment
    bar

 ?

Would that be foo = value bar;

Or simply an error. Or would both be an error?

OK, this isn't related to the patch, but as comment processing was brought
to my attention, I'm wondering how it works for the above.

> 
> This is interpreted as `foo = "value"`.
> This also updates the test script so that it can check the above cases.
> 
> Fixes: 76db5a27a827 ("bootconfig: Add Extra Boot Config support")
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> ---
>  tools/bootconfig/test-bootconfig.sh |   18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)

As for the patch itself:

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve