linux-kernel - Re: [PATCH v2 3/3] ublk: drop ublk_ctrl_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aX1kQQ2xwuP0j12i@fedora>
Date: Sat, 31 Jan 2026 10:09:05 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Jens Axboe <axboe@...nel.dk>,
	Govindarajulu Varadarajan <govind.varadar@...il.com>,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] ublk: drop ublk_ctrl_start_recovery() header
 argument

On Fri, Jan 30, 2026 at 10:14:14AM -0700, Caleb Sander Mateos wrote:
> ublk_ctrl_start_recovery() only uses its const struct ublksrv_ctrl_cmd *
> header argument to log the dev_id. But this value is already available
> in struct ublk_device's ub_number field. So log ub_number instead and
> drop the unused header argument.
> 
> Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>

Looks fine,

Reviewed-by: Ming Lei <ming.lei@...hat.com>


Thanks,
Ming