linux-kernel - Re: [RFC PATCH 0/2] rust: pci: add config space accessors (and a small in-tree user)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h5s2zffe.fsf@posteo.net>
Date: Sat, 31 Jan 2026 02:25:45 +0000
From: Charalampos Mitrodimas <charmitro@...teo.net>
To: Zijing Zhang <zijing.zhang@...rs>
Cc: dakr@...nel.org,  ojeda@...nel.org,  bhelgaas@...gle.com,
  kwilczynski@...nel.org,  boqun.feng@...il.com,  gary@...yguo.net,
  bjorn3_gh@...tonmail.com,  lossin@...nel.org,  a.hindborg@...nel.org,
  aliceryhl@...gle.com,  tmgross@...ch.edu,  linux-pci@...r.kernel.org,
  rust-for-linux@...r.kernel.org,  linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 0/2] rust: pci: add config space accessors (and a
 small in-tree user)

Zijing Zhang <zijing.zhang@...rs> writes:

> Hi Charalampos,
>
> Thanks a lot for the review and for testing the RFC series (and for the Tested-by).
> Much appreciated.
>
> It turns out I missed that PCI config space support for Rust has already landed via
> Zhi Wang’s series:
> https://lore.kernel.org/rust-for-linux/20260121202212.4438-1-zhiw@nvidia.com/
>
> So my RFC is redundant and I’ll stop pushing it to avoid wasting reviewers’ time.
> Sorry for the noise.

Mistakes happen, I also missed it myself.

Cheers,
C. Mitrodimas

>
> However, Gary pointed out a real usability/doc issue in the current API: while
> `ConfigSpaceKind`/`ConfigSpaceSize` are re-exported from `kernel::pci`, the
> `ConfigSpace` struct itself is not, which makes it hard to name the returned type
> from `Device::config_space*()` and also affects rustdoc.
>
> I’ll send a small follow-up patch to re-export `ConfigSpace` from `kernel::pci`
> shortly.
>
> Thanks again,
> Zijing