linux-kernel - Re: [PATCH 0/4] crypto: hisilicon/qm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aX1wI7ghvy7-Q-Ii@gondor.apana.org.au>
Date: Sat, 31 Jan 2026 10:59:47 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Chenghai Huang <huangchenghai2@...wei.com>
Cc: davem@...emloft.net, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, fanghao11@...wei.com,
	liulongfang@...wei.com, qianweili@...wei.com,
	wangzhou1@...ilicon.com
Subject: Re: [PATCH 0/4] crypto: hisilicon/qm - fix several mailbox issues

On Sat, Jan 17, 2026 at 06:18:02PM +0800, Chenghai Huang wrote:
> These patchset fix several issues for mailbox handling in the
> hisilicon/qm crypto accelerator driver:
> 1. Fix the memory barrier order in mailbox operations to ensure data is
> up-to-date before hardware access.
> 2. Remove unnecessary architecture-related code, as the driver is
> exclusively used on ARM64.
> 3. Use 128-bit atomic read to replace the current mailbox operations
> in the driver. Since the PF and VFs share the mmio memory of the
> mailbox, mailbox mmio memory access needs to be atomic. Because the
> stp and ldp instructions do not guarantee atomic access to mmio memory
> on all hardware, the current assembly implementation is placed in the
> driver.
> 4. Increase the mailbox wait time for queue and function stop commands
> to match the hardware processing timeout.
> 
> ---
> Chenghai Huang (1):
>   crypto: hisilicon/qm - move the barrier before writing to the mailbox
>     register
> 
> Weili Qian (3):
>   crypto: hisilicon/qm - remove unnecessary code in qm_mb_write()
>   crypto: hisilicon/qm - obtain the mailbox configuration at one time
>   crypto: hisilicon/qm - increase wait time for mailbox
> 
>  drivers/crypto/hisilicon/qm.c | 177 +++++++++++++++++++++-------------
>  include/linux/hisi_acc_qm.h   |   1 +
>  2 files changed, 113 insertions(+), 65 deletions(-)
> 
> -- 
> 2.33.0

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt