linux-kernel - Re: [PATCH] driver core: fix inverted "locked" suffix of driver_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALbr=La5dzZL5EP_x8tcvUWTqfbxPS6T3ZGT520m0Um2voUt=g@mail.gmail.com>
Date: Sat, 31 Jan 2026 13:36:18 +0800
From: Gui-Dong Han <hanguidong02@...il.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: gregkh@...uxfoundation.org, rafael@...nel.org, driver-core@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver core: fix inverted "locked" suffix of driver_match_device()

On Sat, Jan 31, 2026 at 9:46 AM Danilo Krummrich <dakr@...nel.org> wrote:
>
> In the current implementation driver_match_device() expects the device
> lock to be held, while driver_match_device_locked() acquires the device
> lock.
>
> By convention it should be the other way around, hence swap the name of
> both functions.
>
> Fixes: dc23806a7c47 ("driver core: enforce device_lock for driver_match_device()")
> Signed-off-by: Danilo Krummrich <dakr@...nel.org>

Looks good to me. Thanks for fixing the naming convention.

Reviewed-by: Gui-Dong Han <hanguidong02@...il.com>