linux-kernel - Re: [PATCH v2 2/4] LoongArch: Make cpumask_of_node() robust against NUMA_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H5Y-FzdhaNNPUa+P0Enk5hvPxJYAduQGvRUXwDuBaR+HA@mail.gmail.com>
Date: Sat, 31 Jan 2026 16:50:26 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: John Garry <john.g.garry@...cle.com>
Cc: kernel@...0n.name, jiaxun.yang@...goat.com, tsbogend@...ha.franken.de, 
	tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, 
	dave.hansen@...ux.intel.com, hpa@...or.com, luto@...nel.org, 
	peterz@...radead.org, arnd@...db.de, x86@...nel.org, 
	loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	linux-mips@...r.kernel.org, linux-arch@...r.kernel.org, vulab@...as.ac.cn, 
	gregkh@...uxfoundation.org, rafael@...nel.org, dakr@...nel.org
Subject: Re: [PATCH v2 2/4] LoongArch: Make cpumask_of_node() robust against NUMA_NO_NODE

On Fri, Jan 30, 2026 at 8:21 PM John Garry <john.g.garry@...cle.com> wrote:
>
> On 25/01/2026 03:55, Huacai Chen wrote:
> > Reviewed-by: Huacai Chen <chenhuacai@...ngson.cn>
>
> Thanks
>
> So can a loongarch maintainer pick this up please?
OK, applied.

Huacai

>
> >
> > On Wed, Jan 7, 2026 at 5:48 PM John Garry <john.g.garry@...cle.com> wrote:
> >>
> >> The arch definition of cpumask_of_node() cannot handle NUMA_NO_NODE - which
> >> is a valid index - so add a check for this.
> >>
> >> Signed-off-by: John Garry <john.g.garry@...cle.com>
> >> ---
> >>   arch/loongarch/include/asm/topology.h | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/loongarch/include/asm/topology.h b/arch/loongarch/include/asm/topology.h
> >> index f06e7ff25bb7c..6b79d6183085a 100644
> >> --- a/arch/loongarch/include/asm/topology.h
> >> +++ b/arch/loongarch/include/asm/topology.h
> >> @@ -12,7 +12,7 @@
> >>
> >>   extern cpumask_t cpus_on_node[];
> >>
> >> -#define cpumask_of_node(node)  (&cpus_on_node[node])
> >> +#define cpumask_of_node(node)  ((node) == NUMA_NO_NODE ? cpu_all_mask : &cpus_on_node[node])
> >>
> >>   struct pci_bus;
> >>   extern int pcibus_to_node(struct pci_bus *);
> >> --
> >> 2.43.5
> >>
>