linux-kernel - [PATCH] bus: moxtet: fix reference count leak in moxtet_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260131094748.249160-1-salah.triki@gmail.com>
Date: Sat, 31 Jan 2026 10:47:48 +0100
From: Salah Triki <salah.triki@...il.com>
To: Marek Behún <kabel@...nel.org>
Cc: linux-kernel@...r.kernel.org,
	Salah Triki <salah.triki@...il.com>
Subject: [PATCH] bus: moxtet: fix reference count leak in moxtet_add_device()

If `device_add()` fails, the reference count of the device is not
dropped. This leads to a memory leak of the device and its associated
resources.

`put_device()` must be called if `device_add()` fails to properly clean up
the device structure.

Fixes: 5bc7f990cd98f ("bus: Add support for Moxtet bus")

Signed-off-by: Salah Triki <salah.triki@...il.com>
---
 drivers/bus/moxtet.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c
index 7ce61d629a87..35795deba2a9 100644
--- a/drivers/bus/moxtet.c
+++ b/drivers/bus/moxtet.c
@@ -179,9 +179,11 @@ static int moxtet_add_device(struct moxtet_device *dev)
 		goto done;
 
 	ret = device_add(&dev->dev);
-	if (ret < 0)
+	if (ret < 0) {
 		dev_err(dev->moxtet->dev, "can't add %s, status %d\n",
 			dev_name(dev->moxtet->dev), ret);
+		put_device(&dev->dev);
+	}
 
 done:
 	mutex_unlock(&add_mutex);
-- 
2.43.0