linux-kernel - Re: [PATCH v4] staging: rtl8723bs: remove unused private debug counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aX39WL7lOb09D_Qk@stanley.mountain>
Date: Sat, 31 Jan 2026 16:02:16 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ethan Tidmore <ethantidmore06@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] staging: rtl8723bs: remove unused private debug
 counters

On Fri, Jan 30, 2026 at 02:40:51PM -0600, Ethan Tidmore wrote:
> -void rtw_hal_check_rxfifo_full(struct adapter *adapter)
> -{
> -	struct dvobj_priv *psdpriv = adapter->dvobj;
> -	struct debug_priv *pdbgpriv = &psdpriv->drv_dbg;
> -	int save_cnt = false;
> -
> -	/* switch counter to RX fifo */
> -	rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT+3)|0xf0);
        ^^^^^^^^^^
You can't delete this.

> -	save_cnt = true;
> -	/* todo: other chips */
> -
> -	if (save_cnt) {
> -		/* rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT+3)|0xa0); */
> -		pdbgpriv->dbg_rx_fifo_last_overflow = pdbgpriv->dbg_rx_fifo_curr_overflow;
> -		pdbgpriv->dbg_rx_fifo_curr_overflow = rtw_read16(adapter, REG_RXERR_RPT);
> -		pdbgpriv->dbg_rx_fifo_diff_overflow = pdbgpriv->dbg_rx_fifo_curr_overflow-pdbgpriv->dbg_rx_fifo_last_overflow;
> -	}
> -}
> -
>  static u32 Array_kfreemap[] = {
>  	0xf8, 0xe,
>  	0xf6, 0xc,
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
> index 928226679ab4..e4d1b54607c8 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
> @@ -124,7 +124,6 @@ void rtl8723b_InitHalDm(struct adapter *Adapter)
>  
>  void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
>  {
> -	bool fw_current_in_ps_mode = false;
>  	bool bFwPSAwake = true;
>  	u8 hw_init_completed = false;
>  	struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
> @@ -134,16 +133,8 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
>  	if (hw_init_completed == false)
>  		goto skip_dm;
>  
> -	fw_current_in_ps_mode = adapter_to_pwrctl(Adapter)->fw_current_in_ps_mode;

Which means don't delete this either.

regards,
dan carpenter

>  	rtw_hal_get_hwreg(Adapter, HW_VAR_FWLPS_RF_ON, (u8 *)(&bFwPSAwake));
>  
> -	if (
> -		(hw_init_completed == true) &&
> -		((!fw_current_in_ps_mode) && bFwPSAwake)
> -	) {
> -		rtw_hal_check_rxfifo_full(Adapter);
> -	}
> -
>  	/* ODM */
>  	if (hw_init_completed == true) {
>  		u8 bLinked = false;