linux-kernel - Re: [PATCH] kunit: time: use is_leap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aX4ERvTINZ-_eivh@sirena.co.uk>
Date: Sat, 31 Jan 2026 13:31:50 +0000
From: Mark Brown <broonie@...nel.org>
To: Thomas Gleixner <tglx@...nel.org>
Cc: Jinjie Ruan <ruanjinjie@...wei.com>, jstultz@...gle.com,
	sboyd@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kunit: time: use is_leap_year() helper

On Fri, Jan 30, 2026 at 10:13:53PM +0100, Thomas Gleixner wrote:
> On Fri, Jan 30 2026 at 19:39, Mark Brown wrote:

> > The issue here is, of course, the change from using long for the new to
> > using unsigned long.  The test is considering times up to 8000 years
> > before 1970 which results in us trying to convert a negative year to a
> > positive value before testing if it's a leap year which gives us the
> > wrong answer.  I'll send a revert.

> Duh. Don't send anything I just zapped the commit from timers/core

OK, that also works just as well - I'd sent the patch before I saw this
mail, sorry.  Thanks!

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)