linux-kernel - Re: [PATCH 1/3] PCI: dwc: ep: Return after clearing BAR-match inbound mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aX4Q4RWMfXt085lL@fedora>
Date: Sat, 31 Jan 2026 15:25:37 +0100
From: Niklas Cassel <cassel@...nel.org>
To: Koichiro Den <den@...inux.co.jp>
Cc: mani@...nel.org, kwilczynski@...nel.org, kishon@...nel.org,
	bhelgaas@...gle.com, corbet@....net, jingoohan1@...il.com,
	lpieralisi@...nel.org, robh@...nel.org, Frank.Li@....com,
	linux-pci@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] PCI: dwc: ep: Return after clearing BAR-match
 inbound mapping

On Sat, Jan 31, 2026 at 10:36:53PM +0900, Koichiro Den wrote:
> dw_pcie_ep_clear_ib_maps() first checks whether the inbound mapping for
> a BAR is in BAR Match Mode (tracked via ep_func->bar_to_atu[bar]). Once
> found, the iATU region is disabled and the bookkeeping is cleared.
> 
> BAR Match Mode and Address Match Mode mappings are mutually exclusive
> for a given BAR, so there is nothing left for the Address Match Mode
> teardown path to do after the BAR Match Mode mapping has been removed.
> 
> Return early after clearing the BAR Match Mode mapping to avoid running
> the Address Match Mode teardown path. This makes the helper's intention
> explicit and helps detect incorrect use of pci_epc_set_bar().
> 
> Link: https://lore.kernel.org/all/aXtrW7viGZfMNZur@ryzen/
> Suggested-by: Niklas Cassel <cassel@...nel.org>
> Signed-off-by: Koichiro Den <den@...inux.co.jp>
> ---

Reviewed-by: Niklas Cassel <cassel@...nel.org>