| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1f25e668-ff04-4fa7-a7fd-3ed3286edbe6@tuxon.dev>
Date: Sat, 31 Jan 2026 17:43:41 +0200
From: Claudiu Beznea <claudiu.beznea@...on.dev>
To: Alexander Dahl <ada@...rsis.com>
Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Ryan Wanner <ryan.wanner@...rochip.com>,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH v3 02/19] dt-bindings: clock: at91: Split up per SoC
partially
On 1/20/26 16:37, Alexander Dahl wrote:
> Before adding even more new indexes creating more holes in the
> clk at91 drivers pmc_data->chws arrays, split this up.
>
> This is a partial split up only for some of the old PMC definitions.
>
> Binding splitup was proposed for several reasons:
>
> 1) keep the driver code simple, readable, and efficient
> 2) avoid accidental array index duplication
> 3) avoid memory waste by creating more and more unused array members.
>
> Old values are kept to not break dts, and to maintain dt ABI.
>
> Link: https://lore.kernel.org/linux-devicetree/20250207-jailbird-circus-bcc04ee90e05@thorsis.com/T/#u
> Signed-off-by: Alexander Dahl <ada@...rsis.com>
> ---
>
> Notes:
> v3:
> - full splitup for all at91 family SoCs instead of just a few
>
> v2:
> - new patch, not present in v1
>
> .../reset/atmel,at91sam9260-reset.yaml | 3 ++-
> .../dt-bindings/clock/atmel,at91rm9200-pmc.h | 15 ++++++++++++
> .../dt-bindings/clock/atmel,at91sam9260-pmc.h | 16 +++++++++++++
> .../dt-bindings/clock/atmel,at91sam9g45-pmc.h | 15 ++++++++++++
> .../dt-bindings/clock/atmel,at91sam9n12-pmc.h | 15 ++++++++++++
> .../dt-bindings/clock/atmel,at91sam9rl-pmc.h | 15 ++++++++++++
> .../dt-bindings/clock/atmel,at91sam9x5-pmc.h | 15 ++++++++++++
> include/dt-bindings/clock/atmel,sama5d2-pmc.h | 20 ++++++++++++++++
> include/dt-bindings/clock/atmel,sama5d3-pmc.h | 14 +++++++++++
> include/dt-bindings/clock/atmel,sama5d4-pmc.h | 15 ++++++++++++
> .../dt-bindings/clock/microchip,sam9x60-pmc.h | 15 ++++++++++++
> .../dt-bindings/clock/microchip,sam9x7-pmc.h | 19 +++++++++++++++
> .../clock/microchip,sama7d65-pmc.h | 24 +++++++++++++++++++
> .../dt-bindings/clock/microchip,sama7g5-pmc.h | 19 +++++++++++++++
> 14 files changed, 219 insertions(+), 1 deletion(-)
> create mode 100644 include/dt-bindings/clock/atmel,at91rm9200-pmc.h
> create mode 100644 include/dt-bindings/clock/atmel,at91sam9260-pmc.h
> create mode 100644 include/dt-bindings/clock/atmel,at91sam9g45-pmc.h
> create mode 100644 include/dt-bindings/clock/atmel,at91sam9n12-pmc.h
> create mode 100644 include/dt-bindings/clock/atmel,at91sam9rl-pmc.h
> create mode 100644 include/dt-bindings/clock/atmel,at91sam9x5-pmc.h
> create mode 100644 include/dt-bindings/clock/atmel,sama5d2-pmc.h
> create mode 100644 include/dt-bindings/clock/atmel,sama5d3-pmc.h
> create mode 100644 include/dt-bindings/clock/atmel,sama5d4-pmc.h
> create mode 100644 include/dt-bindings/clock/microchip,sam9x60-pmc.h
> create mode 100644 include/dt-bindings/clock/microchip,sam9x7-pmc.h
> create mode 100644 include/dt-bindings/clock/microchip,sama7d65-pmc.h
> create mode 100644 include/dt-bindings/clock/microchip,sama7g5-pmc.h
>
> diff --git a/Documentation/devicetree/bindings/reset/atmel,at91sam9260-reset.yaml b/Documentation/devicetree/bindings/reset/atmel,at91sam9260-reset.yaml
> index 84c4801df8d9a..8c89ccc3d6393 100644
> --- a/Documentation/devicetree/bindings/reset/atmel,at91sam9260-reset.yaml
> +++ b/Documentation/devicetree/bindings/reset/atmel,at91sam9260-reset.yaml
> @@ -67,9 +67,10 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/clock/at91.h>
> + #include <dt-bindings/clock/atmel,at91sam9260-pmc.h>
>
> reset-controller@...ffd00 {
> compatible = "atmel,at91sam9260-rstc";
> reg = <0xfffffd00 0x10>;
> - clocks = <&pmc PMC_TYPE_CORE PMC_SLOW>;
> + clocks = <&pmc PMC_TYPE_CORE AT91SAM9260_PMC_SLOW>;
> };
> diff --git a/include/dt-bindings/clock/atmel,at91rm9200-pmc.h b/include/dt-bindings/clock/atmel,at91rm9200-pmc.h
> new file mode 100644
> index 0000000000000..ab0d0d7a3b655
> --- /dev/null
> +++ b/include/dt-bindings/clock/atmel,at91rm9200-pmc.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91rm9200 clock driver.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_ATMEL_AT91RM9200_PMC_H
> +#define _DT_BINDINGS_CLOCK_ATMEL_AT91RM9200_PMC_H
> +
> +#define AT91RM9200_PMC_MCK 1
> +#define AT91RM9200_PMC_MAIN 3
> +#define AT91RM9200_PMC_PLLACK 7
> +#define AT91RM9200_PMC_PLLBCK 8
> +
> +#endif
> diff --git a/include/dt-bindings/clock/atmel,at91sam9260-pmc.h b/include/dt-bindings/clock/atmel,at91sam9260-pmc.h
> new file mode 100644
> index 0000000000000..6a5453cf70954
> --- /dev/null
> +++ b/include/dt-bindings/clock/atmel,at91sam9260-pmc.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91sam9260 clock driver.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_ATMEL_AT91SAM9260_PMC_H
> +#define _DT_BINDINGS_CLOCK_ATMEL_AT91SAM9260_PMC_H
> +
> +#define AT91SAM9260_PMC_SLOW 0
> +#define AT91SAM9260_PMC_MCK 1
> +#define AT91SAM9260_PMC_MAIN 3
> +#define AT91SAM9260_PMC_PLLACK 7
> +#define AT91SAM9260_PMC_PLLBCK 8
> +
> +#endif
> diff --git a/include/dt-bindings/clock/atmel,at91sam9g45-pmc.h b/include/dt-bindings/clock/atmel,at91sam9g45-pmc.h
> new file mode 100644
> index 0000000000000..63134ecafa50c
> --- /dev/null
> +++ b/include/dt-bindings/clock/atmel,at91sam9g45-pmc.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91sam9g45 clock driver.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_ATMEL_AT91SAM9G45_PMC_H
> +#define _DT_BINDINGS_CLOCK_ATMEL_AT91SAM9G45_PMC_H
> +
> +#define AT91SAM9G45_PMC_MCK 1
> +#define AT91SAM9G45_PMC_UTMI 2
> +#define AT91SAM9G45_PMC_MAIN 3
> +#define AT91SAM9G45_PMC_PLLACK 7
> +
> +#endif
> diff --git a/include/dt-bindings/clock/atmel,at91sam9n12-pmc.h b/include/dt-bindings/clock/atmel,at91sam9n12-pmc.h
> new file mode 100644
> index 0000000000000..e41ad6d68108a
> --- /dev/null
> +++ b/include/dt-bindings/clock/atmel,at91sam9n12-pmc.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91sam9n12 clock driver.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_ATMEL_AT91SAM9N12_PMC_H
> +#define _DT_BINDINGS_CLOCK_ATMEL_AT91SAM9N12_PMC_H
> +
> +#define AT91SAM9N12_PMC_MCK 1
> +#define AT91SAM9N12_PMC_MAIN 3
> +#define AT91SAM9N12_PMC_PLLACK 7
> +#define AT91SAM9N12_PMC_PLLBCK 8
> +
> +#endif
> diff --git a/include/dt-bindings/clock/atmel,at91sam9rl-pmc.h b/include/dt-bindings/clock/atmel,at91sam9rl-pmc.h
> new file mode 100644
> index 0000000000000..4306d457f8d2b
> --- /dev/null
> +++ b/include/dt-bindings/clock/atmel,at91sam9rl-pmc.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91sam9rl clock driver.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_ATMEL_AT91SAM9RL_PMC_H
> +#define _DT_BINDINGS_CLOCK_ATMEL_AT91SAM9RL_PMC_H
> +
> +#define AT91SAM9RL_PMC_MCK 1
> +#define AT91SAM9RL_PMC_UTMI 2
> +#define AT91SAM9RL_PMC_MAIN 3
> +#define AT91SAM9RL_PMC_PLLACK 7
> +
> +#endif
> diff --git a/include/dt-bindings/clock/atmel,at91sam9x5-pmc.h b/include/dt-bindings/clock/atmel,at91sam9x5-pmc.h
> new file mode 100644
> index 0000000000000..d3e612f063a00
> --- /dev/null
> +++ b/include/dt-bindings/clock/atmel,at91sam9x5-pmc.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91sam9x5 clock driver.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_ATMEL_AT91SAM9X5_PMC_H
> +#define _DT_BINDINGS_CLOCK_ATMEL_AT91SAM9X5_PMC_H
> +
> +#define AT91SAM9X5_PMC_MCK 1
> +#define AT91SAM9X5_PMC_UTMI 2
> +#define AT91SAM9X5_PMC_MAIN 3
> +#define AT91SAM9X5_PMC_PLLACK 7
> +
> +#endif
> diff --git a/include/dt-bindings/clock/atmel,sama5d2-pmc.h b/include/dt-bindings/clock/atmel,sama5d2-pmc.h
> new file mode 100644
> index 0000000000000..1690a69087522
> --- /dev/null
> +++ b/include/dt-bindings/clock/atmel,sama5d2-pmc.h
> @@ -0,0 +1,20 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91 sama5d2 clock driver.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_ATMEL_SAMA5D2_PMC_H
> +#define _DT_BINDINGS_CLOCK_ATMEL_SAMA5D2_PMC_H
> +
> +#define SAMA5D2_PMC_MCK 1
> +#define SAMA5D2_PMC_UTMI 2
> +#define SAMA5D2_PMC_MAIN 3
> +#define SAMA5D2_PMC_MCK2 4
> +#define SAMA5D2_PMC_I2S0_MUX 5
> +#define SAMA5D2_PMC_I2S1_MUX 6
> +#define SAMA5D2_PMC_PLLACK 7
> +#define SAMA5D2_PMC_AUDIOPLLCK 9
> +#define SAMA5D2_PMC_AUDIOPINCK 10
> +
> +#endif
> diff --git a/include/dt-bindings/clock/atmel,sama5d3-pmc.h b/include/dt-bindings/clock/atmel,sama5d3-pmc.h
> new file mode 100644
> index 0000000000000..85b772ccd996a
> --- /dev/null
> +++ b/include/dt-bindings/clock/atmel,sama5d3-pmc.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91 sama5d3 clock driver.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_ATMEL_SAMA5D3_PMC_H
> +#define _DT_BINDINGS_CLOCK_ATMEL_SAMA5D3_PMC_H
> +
> +#define SAMA5D3_PMC_MCK 1
> +#define SAMA5D3_PMC_UTMI 2
> +#define SAMA5D3_PMC_PLLACK 7
> +
> +#endif
> diff --git a/include/dt-bindings/clock/atmel,sama5d4-pmc.h b/include/dt-bindings/clock/atmel,sama5d4-pmc.h
> new file mode 100644
> index 0000000000000..15b812e1b9259
> --- /dev/null
> +++ b/include/dt-bindings/clock/atmel,sama5d4-pmc.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91 sama5d4 clock driver.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_ATMEL_SAMA5D4_PMC_H
> +#define _DT_BINDINGS_CLOCK_ATMEL_SAMA5D4_PMC_H
> +
> +#define SAMA5D4_PMC_MCK 1
> +#define SAMA5D4_PMC_UTMI 2
> +#define SAMA5D4_PMC_MCK2 4
> +#define SAMA5D4_PMC_PLLACK 7
> +
> +#endif
> diff --git a/include/dt-bindings/clock/microchip,sam9x60-pmc.h b/include/dt-bindings/clock/microchip,sam9x60-pmc.h
> new file mode 100644
> index 0000000000000..91f8f863ea076
> --- /dev/null
> +++ b/include/dt-bindings/clock/microchip,sam9x60-pmc.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91 sam9x60 clock driver.
s/at91/Microchip. Same for microchip,sam9x7-pmc.h, microchip,sama7d65-pmc.h,
microchip,sama7g5-pmc.h files.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_MICROCHIP_SAM9X60_PMC_H
> +#define _DT_BINDINGS_CLOCK_MICROCHIP_SAM9X60_PMC_H
> +
> +#define SAM9X60_PMC_MCK 1
> +#define SAM9X60_PMC_UTMI 2
> +#define SAM9X60_PMC_MAIN 3
> +#define SAM9X60_PMC_PLLACK 7
> +
> +#endif
> diff --git a/include/dt-bindings/clock/microchip,sam9x7-pmc.h b/include/dt-bindings/clock/microchip,sam9x7-pmc.h
> new file mode 100644
> index 0000000000000..e1dd41fe75046
> --- /dev/null
> +++ b/include/dt-bindings/clock/microchip,sam9x7-pmc.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91 sam9x7 clock driver.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_MICROCHIP_SAM9X7_PMC_H
> +#define _DT_BINDINGS_CLOCK_MICROCHIP_SAM9X7_PMC_H
> +
> +#define SAM9X7_PMC_MCK 1
> +#define SAM9X7_PMC_UTMI 2
> +#define SAM9X7_PMC_MAIN 3
> +#define SAM9X7_PMC_PLLACK 7
You should also keep the other PLLs even if they are not used in device trees.
They are HW specific. Same for the other SoCs.
> +#define SAM9X7_PMC_AUDIOPMCPLL 9
> +#define SAM9X7_PMC_AUDIOIOPLL 10
> +#define SAM9X7_PMC_PLLADIV2 14
> +#define SAM9X7_PMC_LVDSPLL 15
> +
> +#endif
> diff --git a/include/dt-bindings/clock/microchip,sama7d65-pmc.h b/include/dt-bindings/clock/microchip,sama7d65-pmc.h
> new file mode 100644
> index 0000000000000..09d152da6db44
> --- /dev/null
> +++ b/include/dt-bindings/clock/microchip,sama7d65-pmc.h
> @@ -0,0 +1,24 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91 sama7d65 clock driver.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_MICROCHIP_SAMA7D65_PMC_H
> +#define _DT_BINDINGS_CLOCK_MICROCHIP_SAMA7D65_PMC_H
> +
> +#define SAMA7D65_PMC_MCK0 1
> +#define SAMA7D65_PMC_UTMI 2
> +#define SAMA7D65_PMC_MAIN 3
> +#define SAMA7D65_PMC_CPUPLL 4
> +#define SAMA7D65_PMC_SYSPLL 5
Here, you should keep the other PLLs as well.
> +#define SAMA7D65_PMC_BAUDPLL 8
> +#define SAMA7D65_PMC_AUDIOPMCPLL 9
> +#define SAMA7D65_PMC_AUDIOIOPLL 10
> +#define SAMA7D65_PMC_ETHPLL 11
> +#define SAMA7D65_PMC_MCK1 13
> +#define SAMA7D65_PMC_LVDSPLL 15
> +#define SAMA7D65_PMC_MCK3 16
> +#define SAMA7D65_PMC_MCK5 17
> +
> +#endif
> diff --git a/include/dt-bindings/clock/microchip,sama7g5-pmc.h b/include/dt-bindings/clock/microchip,sama7g5-pmc.h
> new file mode 100644
> index 0000000000000..0303cae56f849
> --- /dev/null
> +++ b/include/dt-bindings/clock/microchip,sama7g5-pmc.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * The constants defined in this header are being used in dts and in
> + * at91 sama7g5 clock driver.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_MICROCHIP_SAMA7G5_PMC_H
> +#define _DT_BINDINGS_CLOCK_MICROCHIP_SAMA7G5_PMC_H
> +
> +#define SAMA7G5_PMC_MCK0 1
> +#define SAMA7G5_PMC_UTMI 2
> +#define SAMA7G5_PMC_MAIN 3
> +#define SAMA7G5_PMC_CPUPLL 4
> +#define SAMA7G5_PMC_SYSPLL 5
Same here. Keep the defines for the rest of the PLLs.
> +#define SAMA7G5_PMC_AUDIOPMCPLL 9
> +#define SAMA7G5_PMC_AUDIOIOPLL 10
> +#define SAMA7G5_PMC_MCK1 13
> +
> +#endif
Powered by blists - more mailing lists