linux-kernel - [PATCH 2/2] usb: gadget: f_sourcesink: Use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260131160111.3161630-3-krishna.kurapati@oss.qualcomm.com>
Date: Sat, 31 Jan 2026 21:31:11 +0530
From: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Al Viro <viro@...iv.linux.org.uk>, Sam Day <me@...cday.com>,
        Christian Brauner <brauner@...nel.org>, Chen Ni <nichen@...as.ac.cn>,
        Mateusz Guzik <mjguzik@...il.com>, Liang Jie <liangjie@...iang.com>,
        Ingo Rohloff <ingo.rohloff@...terbach.com>,
        Owen Gu <guhuinan@...omi.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Krishna Kurapati <krishna.kurapati@....qualcomm.com>
Subject: [PATCH 2/2] usb: gadget: f_sourcesink: Use sysfs_emit() in configfs show functions

Use sysfs_emit() instead of sprintf() in configfs attribute show functions.
sysfs_emit() is the recommended API for sysfs output as it provides buffer
overflow protection and proper formatting.

No functional changes.

Signed-off-by: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
---
 drivers/usb/gadget/function/f_sourcesink.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/gadget/function/f_sourcesink.c b/drivers/usb/gadget/function/f_sourcesink.c
index 22104e9c6cab..e6ca80dba7c8 100644
--- a/drivers/usb/gadget/function/f_sourcesink.c
+++ b/drivers/usb/gadget/function/f_sourcesink.c
@@ -900,7 +900,7 @@ static ssize_t f_ss_opts_pattern_show(struct config_item *item, char *page)
 	int result;
 
 	mutex_lock(&opts->lock);
-	result = sprintf(page, "%u\n", opts->pattern);
+	result = sysfs_emit(page, "%u\n", opts->pattern);
 	mutex_unlock(&opts->lock);
 
 	return result;
@@ -943,7 +943,7 @@ static ssize_t f_ss_opts_isoc_interval_show(struct config_item *item, char *page
 	int result;
 
 	mutex_lock(&opts->lock);
-	result = sprintf(page, "%u\n", opts->isoc_interval);
+	result = sysfs_emit(page, "%u\n", opts->isoc_interval);
 	mutex_unlock(&opts->lock);
 
 	return result;
@@ -986,7 +986,7 @@ static ssize_t f_ss_opts_isoc_maxpacket_show(struct config_item *item, char *pag
 	int result;
 
 	mutex_lock(&opts->lock);
-	result = sprintf(page, "%u\n", opts->isoc_maxpacket);
+	result = sysfs_emit(page, "%u\n", opts->isoc_maxpacket);
 	mutex_unlock(&opts->lock);
 
 	return result;
@@ -1029,7 +1029,7 @@ static ssize_t f_ss_opts_isoc_mult_show(struct config_item *item, char *page)
 	int result;
 
 	mutex_lock(&opts->lock);
-	result = sprintf(page, "%u\n", opts->isoc_mult);
+	result = sysfs_emit(page, "%u\n", opts->isoc_mult);
 	mutex_unlock(&opts->lock);
 
 	return result;
@@ -1072,7 +1072,7 @@ static ssize_t f_ss_opts_isoc_maxburst_show(struct config_item *item, char *page
 	int result;
 
 	mutex_lock(&opts->lock);
-	result = sprintf(page, "%u\n", opts->isoc_maxburst);
+	result = sysfs_emit(page, "%u\n", opts->isoc_maxburst);
 	mutex_unlock(&opts->lock);
 
 	return result;
@@ -1158,7 +1158,7 @@ static ssize_t f_ss_opts_bulk_buflen_show(struct config_item *item, char *page)
 	int result;
 
 	mutex_lock(&opts->lock);
-	result = sprintf(page, "%u\n", opts->bulk_buflen);
+	result = sysfs_emit(page, "%u\n", opts->bulk_buflen);
 	mutex_unlock(&opts->lock);
 
 	return result;
@@ -1196,7 +1196,7 @@ static ssize_t f_ss_opts_bulk_qlen_show(struct config_item *item, char *page)
 	int result;
 
 	mutex_lock(&opts->lock);
-	result = sprintf(page, "%u\n", opts->bulk_qlen);
+	result = sysfs_emit(page, "%u\n", opts->bulk_qlen);
 	mutex_unlock(&opts->lock);
 
 	return result;
@@ -1234,7 +1234,7 @@ static ssize_t f_ss_opts_iso_qlen_show(struct config_item *item, char *page)
 	int result;
 
 	mutex_lock(&opts->lock);
-	result = sprintf(page, "%u\n", opts->iso_qlen);
+	result = sysfs_emit(page, "%u\n", opts->iso_qlen);
 	mutex_unlock(&opts->lock);
 
 	return result;
-- 
2.34.1