linux-kernel - Re: [PATCH] iio: light: bh1780: fix PM runtime leak on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260131170536.48a16474@jic23-huawei>
Date: Sat, 31 Jan 2026 17:05:36 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Linus Walleij <linusw@...nel.org>
Cc: Antoniu Miclaus <antoniu.miclaus@...log.com>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>, Ulf Hansson
 <ulf.hansson@...aro.org>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: light: bh1780: fix PM runtime leak on error path

On Fri, 30 Jan 2026 14:16:36 +0100
Linus Walleij <linusw@...nel.org> wrote:

> On Fri, Jan 30, 2026 at 12:31 PM Antoniu Miclaus
> <antoniu.miclaus@...log.com> wrote:
> 
> > Move pm_runtime_put_autosuspend() before the error check to ensure
> > the PM runtime reference count is always decremented after
> > pm_runtime_get_sync(), regardless of whether the read operation
> > succeeds or fails.
> >
> > Fixes: 1f0477f18306 ("iio: light: new driver for the ROHM BH1780")
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>  
> 
> This looks right!
> Reviewed-by: Linus Walleij <linusw@...nel.org>
I've applied this to my local tree for now.  Given where we are in the
cycle this likely won't go out until after the merge window when
I have rebased on rc1.

Thanks,

Jonathan

> 
> Yours,
> Linus Walleij