linux-kernel - Re: [PATCH next 2/4] iio: sca3000: switch IRQ handling to devm helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd790183-8c26-405d-9583-28eb34d3d73a@oracle.com>
Date: Sat, 31 Jan 2026 23:04:30 +0530
From: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: David Lechner <dlechner@...libre.com>,
        Nuno Sá
 <nuno.sa@...log.com>,
        Andy Shevchenko <andy@...nel.org>,
        Andrew Ijano <andrew.ijano@...il.com>,
        "open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...el.com>
Subject: Re: [PATCH next 2/4] iio: sca3000: switch IRQ handling to devm
 helpers

Hi Jonathan,


On 31/01/26 22:00, Jonathan Cameron wrote:
>>   
>>   	if (spi->irq) {
>> -		ret = request_threaded_irq(spi->irq,
>> -					   NULL,
>> +		ret = devm_request_threaded_irq(dev, spi->irq, NULL,
>>   					   &sca3000_event_handler,
> Update the indent to keep these after the (
> That is:
> 		ret = devm_request_threaded_irq(dev, spi->irq, NULL,
>   						&sca3000_event_handler,
> 						IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> 						"sca3000",
> etc
> 

Oh, right, I should have indented it properly, sorry about that. I 
thought checkpatch was catching these. Will fix this in a next version. 
Thanks for spotting this.

Regards,
Harshit