linux-kernel - Re: [PATCH v2] staging: rtl8723bs: replace ternary comparison with min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aX49e37jGXj674bq@stanley.mountain>
Date: Sat, 31 Jan 2026 20:35:55 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: David Laight <david.laight.linux@...il.com>
Cc: William Hansen-Baird <william.hansen.baird@...il.com>,
	gregkh@...uxfoundation.org, straube.linux@...il.com,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: replace ternary comparison with
 min_t()

On Sat, Jan 31, 2026 at 03:55:25PM +0000, David Laight wrote:
> > > @@ -1024,7 +1025,7 @@ static unsigned short rtw_parse_assoc_security_ies(struct adapter *padapter,
> > >  			pstat->flags |= WLAN_STA_WPS;
> > >  			copy_len = 0;
> > >  		} else {
> > > -			copy_len = ((wpa_ie_len+2) > sizeof(pstat->wpa_ie)) ? (sizeof(pstat->wpa_ie)):(wpa_ie_len+2);
> > > +			copy_len = min_t(int, sizeof(pstat->wpa_ie), wpa_ie_len + 2);  
> > 
> > Use umin().  "int" is wrong because we don't want negative values
> > stored in copy_len.
> 
> And the correct way to fix min() bleating is to change the type of the variables.
> Using min_t() ought to be frowned up and only used as a last resort.
> 
> In this case I think all the variables declared with wpa_ie_len can/should be
> unsigned int.
> 

That also works.

regards,
dan carpenter