linux-kernel - Re: [PATCH v2] staging: axis-fifo: refactor device tree parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aX4-3KP0BqHqaiO4@stanley.mountain>
Date: Sat, 31 Jan 2026 20:41:48 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Gustavo Piaz da Silva <gustavopiazdasilva2102@...il.com>
Cc: gregkh@...uxfoundation.org, ovidiu.panait.oss@...il.com,
	gshahrouzi@...il.com, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: axis-fifo: refactor device tree parsing

The commit message is still not line-wraped.

This patch didn't apply.  The first one did, but this doesn't.

On Sat, Jan 31, 2026 at 12:56:30PM -0300, Gustavo Piaz da Silva wrote:
> Refactor the device tree parsing logic in axis_fifo_probe() to reduce code duplication and improve readability.
> 
> Create a helper function axis_fifo_get_u32() to handle property reading and error checking, replacing repetitive of_property_read_u32() calls.
> 
> Also change has_rx_fifo and has_tx_fifo types from int to u32 in struct axis_fifo to avoid pointer type mismatch warnings, as of_property_read_u32 expects u32 pointers.
> 

I don't understand where this warning is comming from.  The existing
code is calling of_property_read_u32() which also takes a u32 so I
don't see what changed.  I wasn't able to generate a warning on my
end.

Anyway, the u32 change needs to be done as a separate patch.

regards,
dan carpenter