linux-kernel - Re: [PATCH v4] staging: rtl8723bs: fix potential race in expire_timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aX4_OGOZ3OZqN_PF@stanley.mountain>
Date: Sat, 31 Jan 2026 20:43:20 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Minu Jin <s9430939@...er.com>
Cc: gregkh@...uxfoundation.org, bqn9090@...il.com,
	abrahamadekunle50@...il.com, straube.linux@...il.com,
	bryant.boatright@...ton.me, davidzalman.101@...il.com,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] staging: rtl8723bs: fix potential race in
 expire_timeout_chk

On Sun, Feb 01, 2026 at 02:11:53AM +0900, Minu Jin wrote:
> The expire_timeout_chk function currently do lock and unlock inside the
> loop before calling rtw_free_stainfo().
> 
> This can be risky as the list might be changed
> when the lock is briefly released.
> 
> To fix this, move expired sta_info entries into a local free_list while
> holding the lock, and then perform the actual freeing after the lock is
> released.
> 
> Signed-off-by: Minu Jin <s9430939@...er.com>
> Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
> Changes in v4:
>     - Add Reviewed-by tag from Dan Carpenter

No, you don't need to do that.  Greg's scripts adds the tags.  Only add
tags if you need to send another version for a different reason.

Not a big deal, but now you know for next time.

regards,
dan carpenter