linux-kernel - Re: [PATCH 1/8] dt-bindings: clock: qcom,sm8250-videocc: account for the MX domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176988445972.2807015.8710676873473596056.robh@kernel.org>
Date: Sat, 31 Jan 2026 12:34:19 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, 
 Vikash Garodia <vikash.garodia@....qualcomm.com>, 
 Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, 
 Bjorn Andersson <andersson@...nel.org>, linux-media@...r.kernel.org, 
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
 "Rafael J. Wysocki" <rafael@...nel.org>, Taniya Das <quic_tdas@...cinc.com>, 
 Konrad Dybcio <konradybcio@...nel.org>, 
 Dikshita Agarwal <dikshita@....qualcomm.com>, 
 Jonathan Marek <jonathan@...ek.ca>, 
 Stanimir Varbanov <stanimir.varbanov@...aro.org>, 
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Hans Verkuil <hverkuil@...nel.org>, 
 Stefan Schmidt <stefan.schmidt@...aro.org>, linux-arm-msm@...r.kernel.org, 
 linux-clk@...r.kernel.org, Bryan O'Donoghue <bod@...nel.org>, 
 Mauro Carvalho Chehab <mchehab@...nel.org>, linux-pm@...r.kernel.org, 
 Dikshita Agarwal <dikshita.agarwal@....qualcomm.com>, 
 Michael Turquette <mturquette@...libre.com>, 
 Conor Dooley <conor+dt@...nel.org>, Stephen Boyd <sboyd@...nel.org>, 
 Abhinav Kumar <abhinav.kumar@...ux.dev>
Subject: Re: [PATCH 1/8] dt-bindings: clock: qcom,sm8250-videocc: account
 for the MX domain

On Sat, 31 Jan 2026 19:33:43 +0200, Dmitry Baryshkov wrote:
> To configure the video PLLs and enable the video GDSCs on SM8250,
> platform, the MX rail must be ON along with MMCX. Split the bindings
> file in order to provide separate file utilizing MMCX and MX power
> domains.
> 
> Fixes: dafb992a95e1 ("dt-bindings: clock: add SM8250 QCOM video clock bindings")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
>  .../bindings/clock/qcom,sm8250-videocc.yaml        | 80 ++++++++++++++++++++++
>  .../devicetree/bindings/clock/qcom,videocc.yaml    | 20 ------
>  2 files changed, 80 insertions(+), 20 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sm8250-videocc.example.dtb: clock-controller@...0000 (qcom,sm8250-videocc): clock-names:0: 'iface' was expected
	from schema $id: http://devicetree.org/schemas/clock/qcom,sm8250-videocc.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sm8250-videocc.example.dtb: clock-controller@...0000 (qcom,sm8250-videocc): clock-names: ['bi_tcxo'] is too short
	from schema $id: http://devicetree.org/schemas/clock/qcom,sm8250-videocc.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sm8250-videocc.example.dtb: clock-controller@...0000 (qcom,sm8250-videocc): clocks: [[4294967295, 0]] is too short
	from schema $id: http://devicetree.org/schemas/clock/qcom,sm8250-videocc.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260131-iris-venus-fix-sm8250-v1-1-b635ee66284c@oss.qualcomm.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.