linux-kernel - Re: [PATCH] scsi: smartpqi: fix memory leak in pqi_report_phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d0292db-1498-405b-9b30-1e0295d893ab@web.de>
Date: Sat, 31 Jan 2026 20:18:09 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Zilin Guan <zilin@....edu.cn>, linux-scsi@...r.kernel.org,
 Don Brace <don.brace@...rochip.com>
Cc: storagedev@...rochip.com, LKML <linux-kernel@...r.kernel.org>,
 James Bottomley <James.Bottomley@...senPartnership.com>,
 Jianhao Xu <jianhao.xu@....edu.cn>,
 John Donnelly <john.p.donnelly@...cle.com>,
 Mike McGowen <mike.mcgowen@...rochip.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Scott Benesh <scott.benesh@...rochip.com>,
 Scott Teel <scott.teel@...rochip.com>
Subject: Re: [PATCH] scsi: smartpqi: fix memory leak in pqi_report_phys_luns()

…
> Fixes: 28ca6d876c5a ("scsi: smartpqi: Add extended report physical LUNs")
…

See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.19-rc7#n34

…
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
…
> @@ -1275,6 +1278,10 @@ static inline int pqi_report_phys_luns(struct pqi_ctrl_info *ctrl_info, void **b
>  	*buffer = rpl_16byte_wwid_list;
>  
>  	return 0;
> +
> +out_free_rpl_list:
> +	kfree(rpl_list);
> +	return rc;
>  }
…

* How do you think about to refer to the local variable “rpl_8byte_wwid_list” instead?

* Would you like to refine the control flow a bit more for the end
  of this function implementation?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc7#n526

Regards,
Markus