linux-kernel - Re: [PATCH 1/5] staging: rtl8723bs: core/rtw_mlme_ext.c: refactor security IE parsing in OnAssocReq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aX57AZmBhzbKqQoc@william-fedora>
Date: Sat, 31 Jan 2026 16:58:25 -0500
From: William Hansen-Baird <william.hansen.baird@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] staging: rtl8723bs: core/rtw_mlme_ext.c: refactor
 security IE parsing in OnAssocReq

On Tue, Jan 27, 2026 at 03:39:44PM +0100, Greg KH wrote:
> On Fri, Jan 16, 2026 at 11:08:47AM -0500, William Hansen-Baird wrote:
> > +	parse_status = rtw_parse_assoc_security_ies(padapter, &elems, pstat);
> > +	if (parse_status != WLAN_STATUS_SUCCESS)
> > +		status = parse_status;
> >  
> >  	if (status != WLAN_STATUS_SUCCESS)
> >  		goto OnAssocReqFail;
> 
> This logic makes no sense.  Did you do this by hand or have a tool do it
> for you?
> 

I did it by hand. The original code checked the status after parsing
security IEs, only overwriting 'status' on parsing errors. 

To preserve the original logic, I only overwrite 'status' if the parsing 
of the security IEs was not successful.

Thanks,
William