linux-kernel - Re: [PATCH][next] dlm: Avoid -Wflex-array-member-not-at-end warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK-6q+i0wNRRhhkBGNs6oP159vCfa40SjbrLPbQ_P1NXv2EmFg@mail.gmail.com>
Date: Fri, 30 Jan 2026 20:17:15 -0500
From: Alexander Aring <aahringo@...hat.com>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>, David Teigland <teigland@...hat.com>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>, gfs2@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] dlm: Avoid -Wflex-array-member-not-at-end warning

Hi,

On Fri, Jan 30, 2026 at 4:43 PM Gustavo A. R. Silva
<gustavo@...eddedor.com> wrote:
>
> Hi all,
>
> Who can take this, please?
>

Sorry, I will take care that it will be queued up for the next dlm pull-request.
I just checked again if the flexible array member can be accessed
under the current conditions, but I don't see this can be ever the
case... otherwise we would access garbage.

Thanks.

> Thanks
> -Gustavo
>
> On 9/22/25 23:20, Gustavo A. R. Silva wrote:
> > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are
> > getting ready to enable it, globally.
> >
> > Move the conflicting declaration to the end of the corresponding
> > structure. Notice that `struct dlm_message` is a flexible
> > structure, this is a structure that contains a flexible-array
> > member.
> >
> > Fix the following warning:
> >
> > fs/dlm/dlm_internal.h:609:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Acked-by: Alexander Aring <aahringo@...hat.com>

David Teigland can you please apply this patch to dlm/next so we don't
forget it.

Thanks

- Alex