linux-kernel - Re: [PATCH] net: mscc: ocelot: add missing lock protection in ocelot_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260130173912.33ac6c54@kernel.org>
Date: Fri, 30 Jan 2026 17:39:12 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Ziyi Guo <n7l8m4@...orthwestern.edu>
Cc: Vladimir Oltean <vladimir.oltean@....com>, Claudiu Manoil
 <claudiu.manoil@....com>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, UNGLinuxDriver@...rochip.com, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: mscc: ocelot: add missing lock protection in
 ocelot_port_xmit()

On Fri, 30 Jan 2026 02:12:58 +0000 Ziyi Guo wrote:
> ocelot_port_xmit() calls ocelot_can_inject() and ocelot_port_inject_frame()
> without holding ocelot->inj_lock. However, both functions have
> lockdep_assert_held(&ocelot->inj_lock) indicating that callers must hold
> this lock.
> 
> The correct caller felix_port_deferred_xmit() properly acquires the lock
> using ocelot_lock_inj_grp() before calling these functions.
> 
> Add ocelot_lock_inj_grp()/ocelot_unlock_inj_grp() around the injection
> code path in ocelot_port_xmit() to fix the missing lock protection.

Please add an appropriate Fixes tag and repost.
-- 
pw-bot: cr