linux-kernel - Re: crash during resume of PCIe bridge from v5.17 to next-20260130 (v5.16 works)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a4e5667-ae24-403f-8fbd-cb37bd66f055@gmx.de>
Date: Sun, 1 Feb 2026 11:19:46 +0100
From: Armin Wolf <W_Armin@....de>
To: Bert Karwatzki <spasswolf@....de>, Thomas Gleixner <tglx@...nel.org>,
 linux-kernel@...r.kernel.org
Cc: linux-next@...r.kernel.org, Mario Limonciello
 <mario.limonciello@....com>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Clark Williams <clrkwllms@...nel.org>, Steven Rostedt <rostedt@...dmis.org>,
 Christian König <christian.koenig@....com>,
 regressions@...ts.linux.dev, linux-pci@...r.kernel.org,
 linux-acpi@...r.kernel.org, "Rafael J . Wysocki"
 <rafael.j.wysocki@...el.com>, acpica-devel@...ts.linux.dev,
 Robert Moore <robert.moore@...el.com>, Saket Dumbre
 <saket.dumbre@...el.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Clemens Ladisch <clemens@...isch.de>, Jinchao Wang
 <wangjinchao600@...il.com>, Yury Norov <yury.norov@...il.com>,
 Anna Schumaker <anna.schumaker@...cle.com>, Baoquan He <bhe@...hat.com>,
 "Darrick J. Wong" <djwong@...nel.org>, Dave Young <dyoung@...hat.com>,
 Doug Anderson <dianders@...omium.org>,
 "Guilherme G. Piccoli" <gpiccoli@...lia.com>, Helge Deller <deller@....de>,
 Ingo Molnar <mingo@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>,
 Joanthan Cameron <Jonathan.Cameron@...wei.com>,
 Joel Granados <joel.granados@...nel.org>,
 John Ogness <john.ogness@...utronix.de>, Kees Cook <kees@...nel.org>,
 Li Huafei <lihuafei1@...wei.com>, "Luck, Tony" <tony.luck@...el.com>,
 Luo Gengkun <luogengkun@...weicloud.com>,
 Max Kellermann <max.kellermann@...os.com>, Nam Cao <namcao@...utronix.de>,
 oushixiong <oushixiong@...inos.cn>, Petr Mladek <pmladek@...e.com>,
 Qianqiang Liu <qianqiang.liu@....com>,
 Sergey Senozhatsky <senozhatsky@...omium.org>,
 Sohil Mehta <sohil.mehta@...el.com>, Tejun Heo <tj@...nel.org>,
 Thomas Zimemrmann <tzimmermann@...e.de>,
 Thorsten Blum <thorsten.blum@...ux.dev>,
 Ville Syrjala <ville.syrjala@...ux.intel.com>,
 Vivek Goyal <vgoyal@...hat.com>, Yunhui Cui <cuiyunhui@...edance.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: crash during resume of PCIe bridge from v5.17 to next-20260130
 (v5.16 works)

Am 01.02.26 um 01:36 schrieb Bert Karwatzki:

> I found the error, the commit
> ("drm/amd: Check if ASPM is enabled from PCIe subsystem")
> has been applied twice first as cba07cce39ac and a second time
> as 7294863a6f01 after it had been superseeded by commit
> 0ab5d711ec74 ("drm/amd: Refactor `amdgpu_aspm` to be evaluated per device")
> This effectively disables ASPM globally after the built-in GPU (which does not
> support ASPM) is probed. This is the reason for the crashes and loss of devices
> errors which on average occur after ~1000 resumes of the discrete GPU.
>
> snippet from git log --oneline drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c in linux-next:
> 158a05a0b885 drm/amdgpu: Add use_xgmi_p2p module parameter
> 7294863a6f01 drm/amd: Check if ASPM is enabled from PCIe subsystem  <--- This does not belong here!
> b784f42cf78b drm/amdgpu: drop testing module parameter
> 0b1a63487b0f drm/amdgpu: drop benchmark module parameter
> cec2cc7b1c4a drm/amdgpu: Fix typo in *whether* in comment
> 0ab5d711ec74 drm/amd: Refactor `amdgpu_aspm` to be evaluated per device <--- This removes the code from the previous commit.
> cba07cce39ac drm/amd: Check if ASPM is enabled from PCIe subsystem  <--- The first time the commit was applied.
> dfcc3e8c24cc drm/amdgpu: make cyan skillfish support code more consistent
>
> The fix is simply to revert commit 7294863a6f01.
>
> I sent a patch for linux-next (unfortunately without CC'ing stable) and a seperate patch for
> v6.18.8, I hope this does not cause confusion ...
>
> Bert Karwatzki

Good work! Thank you for researching the faulty commit that lead to this strange behavior.

Thanks,
Armin Wolf