linux-kernel - Re: [PATCH] ACPI: battery: fix incorrect charging status when current is zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iEzUgG5t6iYS75BWJJwHMRficwME2GOtfecoM1jWFH1A@mail.gmail.com>
Date: Sun, 1 Feb 2026 13:50:45 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Ata İlhan Köktürk <atailhan2006@...il.com>
Cc: rafael@...nel.org, lenb@...nel.org, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: battery: fix incorrect charging status when current
 is zero

On Thu, Jan 29, 2026 at 3:49 PM Ata İlhan Köktürk
<atailhan2006@...il.com> wrote:
>
> On some laptops, such as the Huawei Matebook series
> the Embedded Controller continues to report "Charging"
> status even when the charge threshold is
> reached and no current is being drawn.
>
> This incorrect reporting prevents the
> system from switching to battery
> power profiles, leading to significantly
> higher power consumption (e.g., 18W
> instead of 7W during browsing) and
> broken battery remaining time estimation.
>
> Validate the "Charging" state
> by checking if rate_now is zero. If the
> hardware reports charging but the current is zero,
> report "Not Charging" to user space.
>
> Signed-off-by: Ata İlhan Köktürk <atailhan2006@...il.com>
> ---
>  drivers/acpi/battery.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index 34181fa52..b4ba8085f 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -211,7 +211,13 @@ static int acpi_battery_get_property(struct power_supply *psy,
>                 if (battery->state & ACPI_BATTERY_STATE_DISCHARGING)
>                         val->intval = acpi_battery_handle_discharging(battery);
>                 else if (battery->state & ACPI_BATTERY_STATE_CHARGING)
> -                       val->intval = POWER_SUPPLY_STATUS_CHARGING;
> +                       /* Check if we can fetch ACPI current info */
> +                       if (battery->rate_now != ACPI_BATTERY_VALUE_UNKNOWN &&
> +                               battery->rate_now == 0)
> +                               /* On charge but no current (0W/0mA) */
> +                               val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
> +                       else
> +                               val->intval = POWER_SUPPLY_STATUS_CHARGING;
>                 else if (battery->state & ACPI_BATTERY_STATE_CHARGE_LIMITING)
>                         val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
>                 else if (acpi_battery_is_charged(battery))
> --

Applied as 6.20/7.0 material, thanks!