linux-kernel - Re: [PATCH v15 6/7] modsign: Enable ML-DSA module signing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2315764.1769964282@warthog.procyon.org.uk>
Date: Sun, 01 Feb 2026 16:44:42 +0000
From: David Howells <dhowells@...hat.com>
To: Michael Kelley <mhklinux@...look.com>,
    Sami Tolvanen <samitolvanen@...gle.com>
Cc: dhowells@...hat.com, Lukas Wunner <lukas@...ner.de>,
    Ignat Korchagin <ignat@...udflare.com>,
    Jarkko Sakkinen <jarkko@...nel.org>,
    Herbert Xu <herbert@...dor.apana.org.au>,
    Eric Biggers <ebiggers@...nel.org>,
    Luis Chamberlain <mcgrof@...nel.org>,
    Petr Pavlu <petr.pavlu@...e.com>, Daniel Gomez <da.gomez@...nel.org>,
    "Jason
 A . Donenfeld" <Jason@...c4.com>,
    Ard Biesheuvel <ardb@...nel.org>,
    Stephan Mueller <smueller@...onox.de>,
    "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
    "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>,
    "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
    "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v15 6/7] modsign: Enable ML-DSA module signing

Michael Kelley <mhklinux@...look.com> wrote:

> I'm building linux-next20260130, which has this patch, and get the following errors:
> 
>   HOSTCC  scripts/sign-file
> scripts/sign-file.c: In function 'main':
> scripts/sign-file.c:282:25: error: 'CMS_NO_SIGNING_TIME' undeclared (first use in this function)
> ...
> The problem is that I'm running on Ubuntu 20.04, with this openssl:
> 
> # openssl version
> OpenSSL 1.1.1f  31 Mar 2020 

The problem probably isn't this patch, it's almost certainly due to:

  d7afd65b4acc7 ("sign-file: Use only the OpenSSL CMS API for signing")

in the modules tree.  It removes support for PKCS#7 signature generation.

Were you using PKCS#7 with SHA1?

David