linux-kernel - Re: [PATCH 1/2] dt-bindings: Add binding document for cm36686

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe99b154-dd88-4fd0-86dd-a61db84d6bfd@baylibre.com>
Date: Sun, 1 Feb 2026 12:45:07 -0600
From: David Lechner <dlechner@...libre.com>
To: Erikas Bitovtas <xerikasxx@...il.com>, Jonathan Cameron
 <jic23@...nel.org>, Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Kevin Tsai <ktsai@...ellamicro.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 phone-devel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: Add binding document for cm36686

On 2/1/26 11:03 AM, Erikas Bitovtas wrote:
> Document the Capella cm36686 ambient light and proximity sensor devicetree
> bindings.
> 
> Signed-off-by: Erikas Bitovtas <xerikasxx@...il.com>
> ---
>  .../bindings/iio/light/capella,cm36686.yaml        | 74 ++++++++++++++++++++++
>  1 file changed, 74 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/capella,cm36686.yaml b/Documentation/devicetree/bindings/iio/light/capella,cm36686.yaml
> new file mode 100644
> index 000000000000..5f0a585e3d87
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/capella,cm36686.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/capella,cm36686.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Capella cm36686 I2C Ambient Light and Proximity sensor
> +
> +maintainers:
> +  - Erikas Bitovtas <xerikasxx@...il.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - capella,cm36686
> +      - capella,cm36672p

The cover letter mentioned that one is fully compatible with the other,
so we should have a fallback here.

  compatible:
    oneOf:
      - const: capella,cm36672p
      - items:
          -const: capella,cm36686
         - const: capella,cm36672p

> +
> +  reg:
> +    maxItems: 1
> +    description:
> +      I2C slave address of the device. Must be 0x60 for both cm36686
> +      and cm36672p sensors.
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description:
> +      Regulator that provides power to the sensor.
> +
> +  vddio-supply:
> +    description:
> +      Regulator used to power IO and I2C bus.
> +
> +  vled-supply:
> +    description:
> +      Regulator used to power proximity LED
> +
> +  proximity-near-level: true
> +
> +  capella,proximity-led-current:

Should use the standard -microamp suffix [1].

[1]: https://github.com/devicetree-org/dt-schema/blob/d16dc68b093e59ec4ae6a32a2e1179cb9cc0fada/dtschema/schemas/property-units.yaml#L86C4-L86C13

> +    description:
> +      Current for proximity IR LED (in uA)
> +    $ref: /schemas/types.yaml#/definitions/uint32

Then we don't need the $ref.

> +    enum: [50, 75, 100, 120, 140, 160, 180, 200]

Should have a default: value since this isn't a required property.

> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg

Power supplies should be required.

> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      light-sensor@60 {
> +        compatible = "capella,cm36686";
> +        reg = <0x60>;
> +
> +        vdd-supply = <&pm8916_l8>;
> +        vddio-supply = <&pm8916_l6>;
> +        vled-supply = <&reg_prox_vled>;
> +
> +        interrupts-extended = <&tlmm 113 IRQ_TYPE_EDGE_FALLING>;
> +
> +        proximity-near-level = <30>;
> +        capella,proximity-led-current = <100>;
> +      };
> +    };
>