linux-kernel - Re: [PATCH v2 2/4] iio: core: Add IIO_EV_INFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afa85a59-07c7-46c9-990a-b0b34599cdc3@baylibre.com>
Date: Sun, 1 Feb 2026 13:06:39 -0600
From: David Lechner <dlechner@...libre.com>
To: Taha Ed-Dafili <0rayn.dev@...il.com>, jic23@...nel.org
Cc: me@...ghamcampbell.com, skhan@...uxfoundation.org,
 linux-kernel-mentees-archive@...ts.linuxfoundation.org,
 rdunlap@...radead.org, nuno.sa@...log.com, andy@...nel.org, corbet@....net,
 lars@...afoo.de, Michael.Hennerich@...log.com, linux-iio@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] iio: core: Add IIO_EV_INFO_SCALE to event info

On 2/1/26 12:33 PM, Taha Ed-Dafili wrote:
> While implementing event scaling for the ADXL345 to match
> the IIO ABI documentation, I noticed that IIO_EV_INFO_SCALE
> was missing from the internal enum iio_event_info.
> 
> Add the constant and the "scale" sysfs string
> to allow drivers to expose these attributes correctly.

I think this could be worded better. The enum member isn't really "missing".
Are there actually any users of these attributes that have implemented
it manually? Or is this something just in the docs but not actually ever
used? I didn't look very hard, but I didn't find any drivers with these
attributes.

> 
> Signed-off-by: Taha Ed-Dafili <0rayn.dev@...il.com>
> ---
>  drivers/iio/industrialio-event.c | 1 +
>  include/linux/iio/types.h        | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
> index 06295cfc2da8..5096baf233f0 100644
> --- a/drivers/iio/industrialio-event.c
> +++ b/drivers/iio/industrialio-event.c
> @@ -256,6 +256,7 @@ static const char * const iio_ev_info_text[] = {
>  	[IIO_EV_INFO_TAP2_MIN_DELAY] = "tap2_min_delay",
>  	[IIO_EV_INFO_RUNNING_PERIOD] = "runningperiod",
>  	[IIO_EV_INFO_RUNNING_COUNT] = "runningcount",
> +	[IIO_EV_INFO_SCALE] = "scale",
>  };
>  
>  static enum iio_event_direction iio_ev_attr_dir(struct iio_dev_attr *attr)
> diff --git a/include/linux/iio/types.h b/include/linux/iio/types.h
> index 34eebad12d2c..4e3099defc1d 100644
> --- a/include/linux/iio/types.h
> +++ b/include/linux/iio/types.h
> @@ -21,6 +21,7 @@ enum iio_event_info {
>  	IIO_EV_INFO_TAP2_MIN_DELAY,
>  	IIO_EV_INFO_RUNNING_PERIOD,
>  	IIO_EV_INFO_RUNNING_COUNT,
> +	IIO_EV_INFO_SCALE,
>  };
>  
>  #define IIO_VAL_INT 1