linux-kernel - [PATCH v6 3/3] dmaengine: dw-axi-dmac: Remove not useful void return function statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260201000500.11882-4-karom.9560@gmail.com>
Date: Sun,  1 Feb 2026 08:04:52 +0800
From: Khairul Anuar Romli <karom.9560@...il.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
	Vinod Koul <vkoul@...nel.org>,
	dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Markus.Elfring@....de,
	Khairul Anuar Romli <karom.9560@...il.com>
Subject: [PATCH v6 3/3] dmaengine: dw-axi-dmac: Remove not useful void return function statements

The dw_axi_dma_set_hw_channel() function is declared as void, so an
explicit `return;` at the end is unnecessary. Control flow naturally
returns to the caller once the function ends. Removing it cleans up the
code and aligns with kernel style guidelines without changing
functionality.

This fix resolves a coding style issue introduced by
- 'commit 32286e279385 ("dmaengine: dw-axi-dmac: Remove free slot check
   algorithm in dw_axi_dma_set_hw_channel")'.

This unnecessary return were detected with the help of the checkpatch.pl
analysis tool with --strict --file option.

Signed-off-by: Khairul Anuar Romli <karom.9560@...il.com>
---
 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index e59725376f8e..c124ac6c8df6 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -593,8 +593,6 @@ static void dw_axi_dma_set_hw_channel(struct axi_dma_chan *chan, bool set)
 			(chan->id * DMA_APB_HS_SEL_BIT_SIZE));
 	reg_value |= (val << (chan->id * DMA_APB_HS_SEL_BIT_SIZE));
 	lo_hi_writeq(reg_value, chip->apb_regs + DMAC_APB_HW_HS_SEL_0);
-
-	return;
 }
 
 /*
-- 
2.43.0