| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20260201224801.609e94d0@pumpkin>
Date: Sun, 1 Feb 2026 22:48:01 +0000
From: David Laight <david.laight.linux@...il.com>
To: Nick Huang <sef1548@...il.com>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>, Robert Moore
<robert.moore@...el.com>, Len Brown <lenb@...nel.org>,
linux-acpi@...r.kernel.org, acpica-devel@...ts.linux.dev,
linux-kernel@...r.kernel.org, paladin@...b.edu.tw, kusogame68@...il.com,
ceyanglab@...il.com, n1136402@...b.edu.tw
Subject: Re: [PATCH 1/2] ACPI: nsrepair2: Replace O(n²)
bubble sort with O(n log n) sort_r()
On Sun, 1 Feb 2026 13:03:33 +0000
Nick Huang <sef1548@...il.com> wrote:
> Replace the O(n²) bubble sort implementation in acpi_ns_sort_list()
> with the kernel's sort_r() function which uses heapsort, providing
> O(n log n) time complexity.
>
> This improves performance for large ACPI package lists while also
> reducing code complexity by leveraging the existing kernel sort API.
What is the break even size?
While the heapsort is O(n long n) it is also more complicated.
There is also the cost of the function call - especially with all the
mitigations that distro kernels are likely to enable.
For large datasets the d-cache locality of both sorts is particularly horrid.
It is almost certainly better to allocate an array of index:value pairs
and sort that.
For very big datasets you want to sort small sections (that fit in the
d-cache) and then use merge sorts (also O(n log n)) to combine them.
(Yes - this is how you sort data with 3 mag-tape drives....)
Oh, in any case, write separate functions for ascending/descending.
David
>
> Signed-off-by: Nick Huang <sef1548@...il.com>
> ---
> drivers/acpi/acpica/nsrepair2.c | 87 +++++++++++++++++++++++----------
> 1 file changed, 62 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/acpi/acpica/nsrepair2.c b/drivers/acpi/acpica/nsrepair2.c
> index 8dbb870f4..a39ef59fe 100644
> --- a/drivers/acpi/acpica/nsrepair2.c
> +++ b/drivers/acpi/acpica/nsrepair2.c
> @@ -9,6 +9,7 @@
> *****************************************************************************/
>
> #include <acpi/acpi.h>
> +#include <linux/sort.h>
> #include "accommon.h"
> #include "acnamesp.h"
>
> @@ -84,6 +85,14 @@ acpi_ns_check_sorted_list(struct acpi_evaluate_info *info,
> static void
> acpi_ns_remove_element(union acpi_operand_object *obj_desc, u32 index);
>
> +/* Context structure for sort comparison function */
> +struct acpi_sort_context {
> + u32 sort_index;
> + u8 sort_direction;
> +};
> +
> +static int acpi_ns_sort_cmp(const void *a, const void *b, const void *priv);
> +
> static void
> acpi_ns_sort_list(union acpi_operand_object **elements,
> u32 count, u32 index, u8 sort_direction);
> @@ -851,6 +860,52 @@ acpi_ns_check_sorted_list(struct acpi_evaluate_info *info,
> return (AE_OK);
> }
>
> +/******************************************************************************
> + *
> + * FUNCTION: acpi_ns_sort_cmp
> + *
> + * PARAMETERS: a - First element to compare
> + * b - Second element to compare
> + * priv - Pointer to sort context (acpi_sort_context)
> + *
> + * RETURN: -1, 0, or 1 depending on sort order
> + *
> + * DESCRIPTION: Comparison function for sort_r() API. Compares the integer
> + * values at the specified index within package elements.
> + *
> + *****************************************************************************/
> +
> +static int acpi_ns_sort_cmp(const void *a, const void *b, const void *priv)
> +{
> + union acpi_operand_object *obj_a = *(union acpi_operand_object **)a;
> + union acpi_operand_object *obj_b = *(union acpi_operand_object **)b;
> + const struct acpi_sort_context *ctx = priv;
> + union acpi_operand_object *value_a;
> + union acpi_operand_object *value_b;
> + u64 a_val;
> + u64 b_val;
> +
> + value_a = obj_a->package.elements[ctx->sort_index];
> + value_b = obj_b->package.elements[ctx->sort_index];
> +
> + a_val = value_a->integer.value;
> + b_val = value_b->integer.value;
> +
> + if (ctx->sort_direction == ACPI_SORT_ASCENDING) {
> + if (a_val < b_val)
> + return -1;
> + if (a_val > b_val)
> + return 1;
> + } else {
> + if (a_val > b_val)
> + return -1;
> + if (a_val < b_val)
> + return 1;
> + }
> +
> + return 0;
> +}
> +
> /******************************************************************************
> *
> * FUNCTION: acpi_ns_sort_list
> @@ -873,31 +928,13 @@ static void
> acpi_ns_sort_list(union acpi_operand_object **elements,
> u32 count, u32 index, u8 sort_direction)
> {
> - union acpi_operand_object *obj_desc1;
> - union acpi_operand_object *obj_desc2;
> - union acpi_operand_object *temp_obj;
> - u32 i;
> - u32 j;
> -
> - /* Simple bubble sort */
> -
> - for (i = 1; i < count; i++) {
> - for (j = (count - 1); j >= i; j--) {
> - obj_desc1 = elements[j - 1]->package.elements[index];
> - obj_desc2 = elements[j]->package.elements[index];
> -
> - if (((sort_direction == ACPI_SORT_ASCENDING) &&
> - (obj_desc1->integer.value >
> - obj_desc2->integer.value))
> - || ((sort_direction == ACPI_SORT_DESCENDING)
> - && (obj_desc1->integer.value <
> - obj_desc2->integer.value))) {
> - temp_obj = elements[j - 1];
> - elements[j - 1] = elements[j];
> - elements[j] = temp_obj;
> - }
> - }
> - }
> + struct acpi_sort_context ctx;
> +
> + ctx.sort_index = index;
> + ctx.sort_direction = sort_direction;
> +
> + sort_r(elements, count, sizeof(union acpi_operand_object *),
> + acpi_ns_sort_cmp, NULL, &ctx);
> }
>
> /******************************************************************************
Powered by blists - more mailing lists